docs: fix typos and grammar across documentation and source#471
Open
Technocrat-dev wants to merge 1 commit intomercari:mainfrom
Open
docs: fix typos and grammar across documentation and source#471Technocrat-dev wants to merge 1 commit intomercari:mainfrom
Technocrat-dev wants to merge 1 commit intomercari:mainfrom
Conversation
- Fix 'toet' to 'to let' in CrossVersionObjectReference comment - Complete incomplete section header in horizontal.md - Fix 'to some extend' to 'to some extent' in horizontal.md - Fix 'developping' to 'developing' in contributor-guide.md - Fix subject-verb agreement 'adapts' to 'adapt' in README.md
Technocrat-dev
requested review from
AVSBharadwaj,
AdityaK011,
dineshbhor,
jrbangit and
randytqwjp
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes a few typos and grammar errors I found while reading through the docs and source comments.
Changes:
Which issue(s) this PR fixes:
N/A (typo/grammar fixes, no issue needed)
Special notes
This is my first contribution to this project. All changes are in docs and comments only, no logic changes.
One thing I noticed but didn't change: in docs/horizontal.md Examples 3 and 4 (lines 171, 179, 199, 207, 211), replicas of 3 are described as "the same as PreferredMaxReplicas", but looking at the context (the section is about reaching the minimum replicas, and
MinimumMinReplicasis 3), I think these should sayMinimumMinReplicasinstead. Left them as-is since I wasn't 100% sure, but wanted to flag it.