-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Add support for ThermoPro TP862b Wireless Dual-Probe Thermometer #3455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Very well written, thanks!
|
|
If I understand correctly you get two wireless probes for one set, right? If both are sending you would get alternating values in the temperature fields and would need to sort them by color when displaying? |
Very good point. As a first time contributor - I really appreciate suggestions! UPD: added color back to have something to identify the probe not through the presence of the temp fields in the payload |
|
The decoder looks good to me. Last suggestion would be to remove the "color" output, it will toggle and not be a good fit for e.g. time series DB. If really needed the sending probe can be identified by the docked and temperature keys already. |
|
To put it antother way, imagine a display in e.g. Home Assistant, would a field of black/white be useable? |
419345a to
1a31845
Compare
|
@zuckschwerdt here's my rationale around this. Please let me know if I'm overthinking it
Imo, this isn't a proper analogy, since the two probes are independent. It just happens so that they are sold in b+w pairs with a display unit, but nothing prevents you from using one or more probes from another set. I.e. a proper analogy would be two weather stations and whether we should or should not combine their readouts in the same message. I'd prefer to have the WDYT? |
|
Okay, makes sense to see it as two independent sensors. The "Color" should be part of the ID then -- which I now see is already the case. |
Technically, the "color" bit is a part of the second byte (b[1]) in the payload, whereas id is the first byte (byte[0]). It looks like id doesn't change, so it's a proper HW identifier of a particular probe. The reason why I think the color bit isn't a part of the id - the second byte also contains the docked/undocked bit, which does change. So, the id can be used to discriminate two different hardware probes, but it doesn't carry information about probe's color.
No worries! Thank you for looking into this. I will update the code and update the output sample in the description later today, when I get back home from work (I'm in PST tz) |
|
Hello @zuckschwerdt , I've updated the code & verified the output (it's in the PR description). |
5c55254 to
7e7b6b1
Compare
7e7b6b1 to
0a7426b
Compare
Add support for ThermoPro TP862b TempSpike XR 1,000-ft Wireless Dual-Probe Meat Thermometer.
https://buythermopro.com/products/tp862b-tempspike-xr-wireless-meat-thermometer
Correctness of the data format verified using two different devices with 2 probes for each.
Output sample: