Add support for TFA Dostmann 30.390X temperature and humidity sensor series #3446

jack77er · 2026-01-16T13:43:14Z

Adding device decoder for TFA Dostmann 30.3905 (temperature, humidity, external temperature) and 30.3902 (temperature, external temperature).

zuckschwerdt · 2026-01-16T15:21:19Z

Thanks! Great work!

The second mention of 30.3905 (line 50) is a typo and should be 30.3902, right?

The sync should be two words, i.e. 0x4b 2dd4 2b. The first byte is the msg_type of 24 or 1e.
And the CRC is now a very plain "CRC-32": poly=0x04c11db7 init=0xffffffff refin=true refout=true xorout=0xffffffff.

zuckschwerdt · 2026-01-16T15:21:57Z

src/devices/tfa_30_3905.c

@@ -0,0 +1,357 @@
+/** @file
+    TFA Dostmann 30.3905 T/H pro sensor with external temp sensor.


Needs to be one sentence, use a comma.

zuckschwerdt · 2026-01-16T15:22:11Z

src/devices/tfa_30_3905.c

+*/
+
+/*
+    TFA Dostmann 30.3905.02 T/H outdoor sensor at 868.025 Mhz.


as above ,

zuckschwerdt · 2026-01-16T15:22:35Z

src/devices/tfa_30_3905.c

+*/
+
+/*
+    TFA Dostmann 30.3905.02 T/H outdoor sensor at 868.025 Mhz.


Indent level here is 0, start at the first column.

zuckschwerdt · 2026-01-16T15:23:10Z

src/devices/tfa_30_3905.c

+    TFA Dostmann 30.3902.02 T outdoor sensor at 868.025 Mhz.
+
+    This device is part of the ID+ sensor system with tfa.me cloud ability.
+    #####


The proper markdown heading would be ## Example for 30.3905:

zuckschwerdt · 2026-01-16T15:23:44Z

src/devices/tfa_30_390X.c

+
+    #####
+                     | Current Frame        | Current Frame -1      | Current Frame -2      |
+    ID        S CNT__ T_INT HUMID T_EXT ????? T_INT HUMID T_EXT ????? T_INT HUMID T_EXT ????? CRC32______


Keep an indent of 4 spaces for these preformatted blocks.

zuckschwerdt · 2026-01-16T15:32:36Z

src/devices/tfa_30_3905.c

+    int i           = 0; // counter variable
+    int start_idx   = 5; // offset for b array skipping the preamble
+    int16_t tmp     = 0;
+    char id_str[30] = {0};


Try to declare vars just when they are used, esp. id_str should be the line above sprintf.

zuckschwerdt · 2026-01-16T15:34:16Z

src/devices/tfa_30_390X.c

+    temp_c_int = decode_value(b, start_idx, 8);
+
+
+    switch(b[start_idx-1]) {


Turn this into a simple if / if else / else, preferably.

src/devices/tfa_30_390x.c

zuckschwerdt · 2026-01-16T15:35:13Z

src/devices/tfa_30_3905.c

+        .name        = "TFA Dostmann 30.3905/02 T/H sensor with external sensor",
+        .modulation  = FSK_PULSE_PCM,
+        .short_width = 61,
+        .long_width  = 61, // unused


It is used ;) Decides between NRZ/RZ.

jack77er · 2026-01-27T08:36:41Z

Sorry for my late response. I've been quite offline for the last two weeks.
Today, i've got additional sensors from the TFA.ID series (30.3908.02, 30.3901.02, 30.3906.02) I'd like to add to the decoder. My question is: should I add a single decoder function for each device or summarize all into one single function? Each one has the same protocol but other datafields like internal temperature, external temperature and humidity.
When using the same function all non available data could be displayed as "n/a". Otherwise the output fields can be reduces to the available data for each sensor.

zuckschwerdt · 2026-01-27T09:00:15Z

If it's the same protocol and some fields are just empty then yes, use the same decoder (with DATA_COND to make fields optional).
If it's just the same timing but different payload then write new decoders. If the decoders are related you can keep them all in the same C file.

Adding more sensors to the decoder. Currently untested, just sync with repo.

…protocol decoding.

jack77er · 2026-01-28T22:16:49Z

Check symbol errors failed, but I don't really understand whats the problem here? Could you help maybe?

Thanks in advance.

zuckschwerdt · 2026-01-28T23:16:59Z

I think it was about sticky parens? Put a space between parens and braces, do not put spaces inside parens.
Also you need /** for the doc-comments (doxygen), e.g. line 18. Don't use it anywhere else.

Add support for TFA Dostmann 30.3905/3902

c6d2cf0

Adding device decoder for TFA Dostmann 30.3905 (temperature, humidity, external temperature) and 30.3902 (temperature, external temperature).

zuckschwerdt reviewed Jan 16, 2026

View reviewed changes

More generalization for sensor series.

a7501a0

Adding more sensors to the decoder. Currently untested, just sync with repo.

jack77er changed the title ~~Add support for TFA Dostmann 30.3905/3902~~ Add support for TFA Dostmann 30.390X temperature and humidity sensor series Jan 27, 2026

Rewrite of most of decoder logic as there was a basic mistake during …

2f36058

…protocol decoding.

jack77er marked this pull request as draft January 28, 2026 15:48

jacob.maxa and others added 3 commits January 28, 2026 16:51

Cleaning up file tree

8ca256d

Code cleanup

1cae55c

Code cleanup merbanan#2

d8ab3bd

jack77er marked this pull request as ready for review January 28, 2026 21:20

cosmetics: satisfy style tests

ece5b68

cosmetics: satisfy style check

90459ee

cosmetics: rename decoder function to fit similar files

f30ab5f

		@@ -0,0 +1,357 @@
		/** @file
		TFA Dostmann 30.3905 T/H pro sensor with external temp sensor.

		temp_c_int = decode_value(b, start_idx, 8);


		switch(b[start_idx-1]) {

Add support for TFA Dostmann 30.390X temperature and humidity sensor series #3446

Are you sure you want to change the base?

Add support for TFA Dostmann 30.390X temperature and humidity sensor series #3446

Conversation

jack77er commented Jan 16, 2026

Uh oh!

zuckschwerdt commented Jan 16, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jack77er commented Jan 27, 2026

Uh oh!

zuckschwerdt commented Jan 27, 2026

Uh oh!

jack77er commented Jan 28, 2026

Uh oh!

zuckschwerdt commented Jan 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants