Update oil_smart.c #3270
Open
Update oil_smart.c #3270
+101
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated oil_smart.c as it did not decode my Apollo sensor. Flex worked so found out id is 32h and there is no inner pre-amble. Analysed data once decoded working and remapped data bits. Hope this is the correct way of contributing - its my first! :-)
Author
|
Happy |
Collaborator
|
Thanks for taking the time to analyze this device fully! Much appreciated. |
zuckschwerdt
reviewed
May 7, 2025
zuckschwerdt
reviewed
May 7, 2025
zuckschwerdt
reviewed
May 7, 2025
zuckschwerdt
reviewed
May 7, 2025
zuckschwerdt
reviewed
May 7, 2025
zuckschwerdt
reviewed
May 7, 2025
zuckschwerdt
reviewed
May 7, 2025
zuckschwerdt
reviewed
May 7, 2025
zuckschwerdt
reviewed
May 7, 2025
Updated to reflect changes suggested by zuckschwerdt
Finishing touches to comments
Updated comments
change spelling mistakes
zuckschwerdt
reviewed
May 8, 2025
Collaborator
|
There is a trailing whitespace in line 68 that needs to be removed for the checks to pass ;) |
zuckschwerdt
reviewed
May 8, 2025
Collaborator
|
What is |
Update model number and mode B to unknown
Author
|
All updates have now been applied - are we ready to approve the pull request? |
zuckschwerdt
force-pushed
the
master
branch
2 times, most recently
from
8d2ffe8 to
a796732
Compare
zuckschwerdt
force-pushed
the
master
branch
3 times, most recently
from
2e725ca to
5e76779
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated oil_smart.c as it did not decode my Apollo sensor. Flex worked so found out id is 32h and there is no inner pre-amble. Analysed data once decoded working and remapped data bits.
Hope this is the correct way of contributing - its my first! :-)