Skip to content

Update CHANGELOG for version 5.0.7, enhancing error handling in API client retry logic and fixing type definition in RequestApplianceUpdateNetworkApplianceFirewallL3FirewallRules struct. #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fmunozmiranda merged 1 commit into from
Sep 2, 2025
Merged

Update CHANGELOG for version 5.0.7, enhancing error handling in API client retry logic and fixing type definition in RequestApplianceUpdateNetworkApplianceFirewallL3FirewallRules struct. #74

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

## [5.0.7] - 2025-01-27
### Fixed
- Enhanced error handling in API client retry logic by adding `resp.IsError()` check before returning responses.
- Fixed type definition in `RequestApplianceUpdateNetworkApplianceFirewallL3FirewallRules` struct by changing `Rules` field from `*[]RequestApplianceUpdateNetworkApplianceFirewallL3FirewallRulesRules` to `[]RequestApplianceUpdateNetworkApplianceFirewallL3FirewallRulesRules` (removed pointer from slice).

## [5.0.6] - 2025-07-29
### Added
- Fix `port` type, from `*int` to `string`.
Expand Down Expand Up @@ -1492,4 +1497,5 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
[5.0.4]: https://github.com/meraki/dashboard-api-go/compare/v5.0.3...5.0.4
[5.0.5]: https://github.com/meraki/dashboard-api-go/compare/v5.0.4...5.0.5
[5.0.6]: https://github.com/meraki/dashboard-api-go/compare/v5.0.5...5.0.6
[Unreleased]: https://github.com/meraki/dashboard-api-go/compare/v5.0.6...main
[5.0.7]: https://github.com/meraki/dashboard-api-go/compare/v5.0.6...5.0.7
[Unreleased]: https://github.com/meraki/dashboard-api-go/compare/v5.0.7...main
3 changes: 3 additions & 0 deletions sdk/api_client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -719,6 +719,9 @@ func doWithRetriesAndNotResult(
}

if resp != nil && resp.StatusCode() != http.StatusTooManyRequests {
if resp.IsError() {
return resp, fmt.Errorf("error with operation: %s", resp.Request.URL)
}
return resp, nil
}

Expand Down
4 changes: 2 additions & 2 deletions sdk/appliance.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2428,8 +2428,8 @@ type RequestApplianceUpdateNetworkApplianceFirewallInboundFirewallRulesRules str
SyslogEnabled *bool `json:"syslogEnabled,omitempty"` // Log this rule to syslog (true or false, boolean value) - only applicable if a syslog has been configured (optional)
}
type RequestApplianceUpdateNetworkApplianceFirewallL3FirewallRules struct {
Rules *[]RequestApplianceUpdateNetworkApplianceFirewallL3FirewallRulesRules `json:"rules,omitempty"` // An ordered array of the firewall rules (not including the default rule)
SyslogDefaultRule *bool `json:"syslogDefaultRule,omitempty"` // Log the special default rule (boolean value - enable only if you've configured a syslog server) (optional)
Rules []RequestApplianceUpdateNetworkApplianceFirewallL3FirewallRulesRules `json:"rules"` // An ordered array of the firewall rules (not including the default rule)
SyslogDefaultRule *bool `json:"syslogDefaultRule,omitempty"` // Log the special default rule (boolean value - enable only if you've configured a syslog server) (optional)
}
type RequestApplianceUpdateNetworkApplianceFirewallL3FirewallRulesRules struct {
Comment string `json:"comment,omitempty"` // Description of the rule (optional)
Expand Down