-
Notifications
You must be signed in to change notification settings - Fork 1
Pe 398 2.5 automation #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The script worked great on my end! Thanks for writing out all of the steps - this PR will serve as useful reference/documentation in the future. Are you also getting the Dart Sass warnings? |
|
I am not I will check my version in the morning for comparison.
…On Thu, Jan 2, 2025, 5:47 PM Gabriela Hanna ***@***.***> wrote:
The script worked great on my end! Thanks for writing out all of the steps
- this PR will serve as useful reference/documentation in the future.
Are you also getting the Dart Sass warnings?
Deprecation Warning: Sass @import rules are deprecated and will be removed in Dart Sass 3.0.0.
More info and automated migrator: https://sass-lang.com/d/import
—
Reply to this email directly, view it on GitHub
<#33 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABQLNQBVCXUNBIWFK2D2ML2IXFZBAVCNFSM6AAAAABUQX57QKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRYGUZDQNZRGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
I went ahead and made the change to move over the Sass-built files in a
|

Local scripts
I've added the automation based on
npm version patchthat will do the following:package.jsonanddistfolders to the branchOn #4 .. I think this is a decent way to play in the middle to see how far we want to go. You can always delete tags and recreate them locally prior to pushing to the repo. Once there, it's slightly harder to take them out. Once you have everything set up the way you like it, just run
git push --tagsto move whatever you have up. We can turn off that automated tag creation with an optional flag if you'd like.Github Actions
It's currently setup to run manually, but the file performs the following steps:
jqdistfolder to our standard bucket at the pathmc-high-impact/sds/$versionThoughts. For 2.5 we only use the pre-built versions, so I am putting those directly into that folder in the bucket. If we wanted to also move up all the CSS files, that's very easy to do and I would recommend adding a layer like so:
mc-high-impact/sds/$version/dist/*.cssmc-high-impact/sds/$version/css/atoms.css(and all the others)This would be very easy to do, so if you like that idea put in a change request and I'll do it before we merge. I do think 3.0 should house both like this if you're on the fence and that pushes you one way or the other.