Skip to content

l10n: allow translating a header and fix a French translation #2315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mbnuqw merged 2 commits into from
Dec 7, 2025
Merged

l10n: allow translating a header and fix a French translation #2315

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8fee130
l10n: fix mistake in French translation
ariasuni Nov 11, 2025
0d93d14
l10n: allow translating “Grant permissions” header
ariasuni Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/_locales/dict.common.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,10 @@ export const commonTranslations: Translations = {
zh: '更新',
ja: '更新',
},
'btn.grant_permissions': {
en: 'Grant permissions',
fr: 'Accorder les permissions',
},
'btn.yes': {
en: 'Yes',
de: 'Ja',
Expand Down
2 changes: 1 addition & 1 deletion src/_locales/dict.setup-page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1138,7 +1138,7 @@ Liste de “sous-chaines” ou “/RegExp/” avec une entrée par ligne:
'settings.copy_title_url_indent': {
en: 'Append an indent for child tabs/bookmarks on copying',
de: 'Beim Kopieren einen Einzug für untergeordnete Tabs/Lesezeichen anfügen',
fr: 'Ajouter une identation pour les onglets ou marque-pages enfants lors de la copie',
fr: 'Ajouter une indentation pour les onglets ou marque-pages enfants lors de la copie',
hu: 'Behúzás hozzáfűzése a gyermek tabulátorokhoz/könyvjelzőkhöz másolásakor',
pl: 'Dołącz wcięcie dla kart/zakładek podrzędnych podczas kopiowania',
ru: 'Добавлять отступ для дочерних вкладок/закладок при копировании',
Expand Down
4 changes: 3 additions & 1 deletion src/sidebar/components/panel-placeholder.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,14 @@ Transition(name="panel-placeholder")
.PanelPlaceholder(v-if="props.isLoading || isMsg || isNotPerm" :data-loading="isLoading")
.perm-warn(v-if="isNotPerm && perm")
.perm-warn-msg {{permMsg}}
.btn.perm-warn-btn(@click="requestPermission") Grant permissions
.btn.perm-warn-btn(@click="requestPermission") {{translate('btn.grant_permissions')}}
LoadingDots(v-else-if="props.isLoading")
.msg(v-else-if="props.isMsg") {{props.msg}}
</template>

<script lang="ts" setup>
import { translate } from 'src/dict'

import LoadingDots from 'src/components/loading-dots.vue'
import { Permissions } from 'src/services/permissions'
import { RequestablePermission } from 'src/services/permissions.actions'
Expand Down