Skip to content

ENG-4369: Update golangci-lint to 2.11.3 via mise#224

Merged
horgh merged 1 commit intomainfrom
greg/eng-4369
Mar 10, 2026
Merged

ENG-4369: Update golangci-lint to 2.11.3 via mise#224
horgh merged 1 commit intomainfrom
greg/eng-4369

Conversation

@oschwald
Copy link
Member

Summary

  • Update golangci-lint from 2.10.1 to 2.11.3 in mise.lock
  • Add disable_backends, hooks, and watch_files settings to mise.toml

Test plan

  • golangci-lint run ./... passes locally
  • CI passes on PR

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@gemini-code-assist
Copy link

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the mise configuration to enhance development environment management. It primarily focuses on upgrading the golangci-lint tool to its latest version and refining how mise interacts with the project by disabling specific backends and automating tool installation through hooks and file watching. These changes aim to improve consistency and efficiency in the development workflow.

Highlights

  • golangci-lint Update: Updated golangci-lint to version 2.11.3 in mise.lock, including updated checksums and the addition of provenance information for all supported platforms.
  • mise Configuration Enhancements: Introduced new mise.toml configurations including disable_backends for asdf and vfox, an enter hook to automatically run mise install --quiet, and watch_files to trigger mise install --quiet on changes to mise.toml or mise.lock.
  • Tool Version Expansion: Added support for newer versions of Go (1.26.1) and Node.js (25.8.0) in mise.lock, alongside existing versions.
Changelog
  • mise.lock
    • Updated golangci-lint from 2.10.1 to 2.11.3, including new checksums and the addition of provenance details for all supported platforms.
    • Added go version 1.26.1 and node version 25.8.0 entries, expanding the range of supported tool versions.
    • Restructured the platform-specific configuration for golangci-lint, precious, go, hugo, and node from inline tables to dedicated TOML tables, and introduced musl variants for Linux platforms.
    • Added a comment indicating the file is auto-generated by mise lock.
  • mise.toml
    • Removed the locked = true setting.
    • Added disable_backends to exclude asdf and vfox from mise's backend usage.
    • Configured an enter hook to automatically run mise install --quiet when entering the project directory.
    • Added watch_files to trigger mise install --quiet when mise.toml or mise.lock are modified.
Activity
  • The author, oschwald, created this pull request to update golangci-lint and configure mise.
  • The author has verified that golangci-lint run ./... passes locally.
  • The author is awaiting CI to pass on the PR.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates golangci-lint and makes several improvements to the mise configuration. The changes to mise.toml to use newer features like disable_backends, hooks, and watch_files are good enhancements.

However, the use of latest for tool versions in mise.toml has led to unintended updates of go and node alongside golangci-lint. This also resulted in the mise.lock file containing multiple versions for these tools, which is not ideal for reproducibility and clarity.

I've added a comment in mise.lock with a recommendation to pin tool versions in mise.toml. This is a best practice for dependency management that will prevent such issues in the future.

Note: Security Review has been skipped due to the limited scope of the PR.

Comment on lines 88 to +122
[[tools.go]]
version = "1.26.0"
backend = "core:go"
"platforms.linux-arm64" = { checksum = "sha256:bd03b743eb6eb4193ea3c3fd3956546bf0e3ca5b7076c8226334afe6b75704cd", url = "https://dl.google.com/go/go1.26.0.linux-arm64.tar.gz"}
"platforms.linux-x64" = { checksum = "sha256:aac1b08a0fb0c4e0a7c1555beb7b59180b05dfc5a3d62e40e9de90cd42f88235", url = "https://dl.google.com/go/go1.26.0.linux-amd64.tar.gz"}
"platforms.macos-arm64" = { checksum = "sha256:b1640525dfe68f066d56f200bef7bf4dce955a1a893bd061de6754c211431023", url = "https://dl.google.com/go/go1.26.0.darwin-arm64.tar.gz"}
"platforms.macos-x64" = { checksum = "sha256:1ca28b7703cbea05a65b2a1d92d6b308610ef92f8824578a0874f2e60c9d5a22", url = "https://dl.google.com/go/go1.26.0.darwin-amd64.tar.gz"}
"platforms.windows-x64" = { checksum = "sha256:9bbe0fc64236b2b51f6255c05c4232532b8ecc0e6d2e00950bd3021d8a4d07d4", url = "https://dl.google.com/go/go1.26.0.windows-amd64.zip"}

[tools.go."platforms.linux-arm64"]
checksum = "sha256:bd03b743eb6eb4193ea3c3fd3956546bf0e3ca5b7076c8226334afe6b75704cd"
url = "https://dl.google.com/go/go1.26.0.linux-arm64.tar.gz"

[tools.go."platforms.linux-arm64-musl"]
checksum = "sha256:bd03b743eb6eb4193ea3c3fd3956546bf0e3ca5b7076c8226334afe6b75704cd"
url = "https://dl.google.com/go/go1.26.0.linux-arm64.tar.gz"

[tools.go."platforms.linux-x64"]
checksum = "sha256:aac1b08a0fb0c4e0a7c1555beb7b59180b05dfc5a3d62e40e9de90cd42f88235"
url = "https://dl.google.com/go/go1.26.0.linux-amd64.tar.gz"

[tools.go."platforms.linux-x64-musl"]
checksum = "sha256:aac1b08a0fb0c4e0a7c1555beb7b59180b05dfc5a3d62e40e9de90cd42f88235"
url = "https://dl.google.com/go/go1.26.0.linux-amd64.tar.gz"

[tools.go."platforms.macos-arm64"]
checksum = "sha256:b1640525dfe68f066d56f200bef7bf4dce955a1a893bd061de6754c211431023"
url = "https://dl.google.com/go/go1.26.0.darwin-arm64.tar.gz"

[tools.go."platforms.macos-x64"]
checksum = "sha256:1ca28b7703cbea05a65b2a1d92d6b308610ef92f8824578a0874f2e60c9d5a22"
url = "https://dl.google.com/go/go1.26.0.darwin-amd64.tar.gz"

[tools.go."platforms.windows-x64"]
checksum = "sha256:9bbe0fc64236b2b51f6255c05c4232532b8ecc0e6d2e00950bd3021d8a4d07d4"
url = "https://dl.google.com/go/go1.26.0.windows-amd64.zip"

[[tools.go]]
version = "1.26.1"
backend = "core:go"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The lock file now contains two versions of Go (1.26.0 and 1.26.1), and similarly for Node. This is likely because these tools are configured with version = "latest" in mise.toml. While this PR's goal is to update golangci-lint, it's also implicitly updating other tools.

Using latest can lead to non-reproducible builds and makes it hard to track when a dependency was updated. It's a best practice to pin tools to specific versions.

I recommend changing mise.toml to use specific versions for all tools. For example:

[tools]
go = "1.26.1"
hugo = "0.157.0"
node = "25.8.0"
"github:golangci/golangci-lint" = "2.11.3"
"github:houseabsolute/precious" = "0.10.2"
"npm:prettier" = "3.8.1"

After updating mise.toml, please regenerate the mise.lock file (e.g., by removing it and running mise install) to ensure it's clean and only contains single, pinned versions for each tool. This will also make the PR's scope clearer.

@horgh horgh merged commit 810657d into main Mar 10, 2026
12 checks passed
@horgh horgh deleted the greg/eng-4369 branch March 10, 2026 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants