ENG-4369: Update golangci-lint to 2.11.3 via mise#224
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates golangci-lint and makes several improvements to the mise configuration. The changes to mise.toml to use newer features like disable_backends, hooks, and watch_files are good enhancements.
However, the use of latest for tool versions in mise.toml has led to unintended updates of go and node alongside golangci-lint. This also resulted in the mise.lock file containing multiple versions for these tools, which is not ideal for reproducibility and clarity.
I've added a comment in mise.lock with a recommendation to pin tool versions in mise.toml. This is a best practice for dependency management that will prevent such issues in the future.
Note: Security Review has been skipped due to the limited scope of the PR.
| [[tools.go]] | ||
| version = "1.26.0" | ||
| backend = "core:go" | ||
| "platforms.linux-arm64" = { checksum = "sha256:bd03b743eb6eb4193ea3c3fd3956546bf0e3ca5b7076c8226334afe6b75704cd", url = "https://dl.google.com/go/go1.26.0.linux-arm64.tar.gz"} | ||
| "platforms.linux-x64" = { checksum = "sha256:aac1b08a0fb0c4e0a7c1555beb7b59180b05dfc5a3d62e40e9de90cd42f88235", url = "https://dl.google.com/go/go1.26.0.linux-amd64.tar.gz"} | ||
| "platforms.macos-arm64" = { checksum = "sha256:b1640525dfe68f066d56f200bef7bf4dce955a1a893bd061de6754c211431023", url = "https://dl.google.com/go/go1.26.0.darwin-arm64.tar.gz"} | ||
| "platforms.macos-x64" = { checksum = "sha256:1ca28b7703cbea05a65b2a1d92d6b308610ef92f8824578a0874f2e60c9d5a22", url = "https://dl.google.com/go/go1.26.0.darwin-amd64.tar.gz"} | ||
| "platforms.windows-x64" = { checksum = "sha256:9bbe0fc64236b2b51f6255c05c4232532b8ecc0e6d2e00950bd3021d8a4d07d4", url = "https://dl.google.com/go/go1.26.0.windows-amd64.zip"} | ||
|
|
||
| [tools.go."platforms.linux-arm64"] | ||
| checksum = "sha256:bd03b743eb6eb4193ea3c3fd3956546bf0e3ca5b7076c8226334afe6b75704cd" | ||
| url = "https://dl.google.com/go/go1.26.0.linux-arm64.tar.gz" | ||
|
|
||
| [tools.go."platforms.linux-arm64-musl"] | ||
| checksum = "sha256:bd03b743eb6eb4193ea3c3fd3956546bf0e3ca5b7076c8226334afe6b75704cd" | ||
| url = "https://dl.google.com/go/go1.26.0.linux-arm64.tar.gz" | ||
|
|
||
| [tools.go."platforms.linux-x64"] | ||
| checksum = "sha256:aac1b08a0fb0c4e0a7c1555beb7b59180b05dfc5a3d62e40e9de90cd42f88235" | ||
| url = "https://dl.google.com/go/go1.26.0.linux-amd64.tar.gz" | ||
|
|
||
| [tools.go."platforms.linux-x64-musl"] | ||
| checksum = "sha256:aac1b08a0fb0c4e0a7c1555beb7b59180b05dfc5a3d62e40e9de90cd42f88235" | ||
| url = "https://dl.google.com/go/go1.26.0.linux-amd64.tar.gz" | ||
|
|
||
| [tools.go."platforms.macos-arm64"] | ||
| checksum = "sha256:b1640525dfe68f066d56f200bef7bf4dce955a1a893bd061de6754c211431023" | ||
| url = "https://dl.google.com/go/go1.26.0.darwin-arm64.tar.gz" | ||
|
|
||
| [tools.go."platforms.macos-x64"] | ||
| checksum = "sha256:1ca28b7703cbea05a65b2a1d92d6b308610ef92f8824578a0874f2e60c9d5a22" | ||
| url = "https://dl.google.com/go/go1.26.0.darwin-amd64.tar.gz" | ||
|
|
||
| [tools.go."platforms.windows-x64"] | ||
| checksum = "sha256:9bbe0fc64236b2b51f6255c05c4232532b8ecc0e6d2e00950bd3021d8a4d07d4" | ||
| url = "https://dl.google.com/go/go1.26.0.windows-amd64.zip" | ||
|
|
||
| [[tools.go]] | ||
| version = "1.26.1" | ||
| backend = "core:go" |
There was a problem hiding this comment.
The lock file now contains two versions of Go (1.26.0 and 1.26.1), and similarly for Node. This is likely because these tools are configured with version = "latest" in mise.toml. While this PR's goal is to update golangci-lint, it's also implicitly updating other tools.
Using latest can lead to non-reproducible builds and makes it hard to track when a dependency was updated. It's a best practice to pin tools to specific versions.
I recommend changing mise.toml to use specific versions for all tools. For example:
[tools]
go = "1.26.1"
hugo = "0.157.0"
node = "25.8.0"
"github:golangci/golangci-lint" = "2.11.3"
"github:houseabsolute/precious" = "0.10.2"
"npm:prettier" = "3.8.1"After updating mise.toml, please regenerate the mise.lock file (e.g., by removing it and running mise install) to ensure it's clean and only contains single, pinned versions for each tool. This will also make the PR's scope clearer.
Summary
disable_backends,hooks, andwatch_filessettings to mise.tomlTest plan
🤖 Generated with Claude Code