Add autoCapitalize on textInput#51
Open
micheleantonazzi wants to merge 4 commits intomaxkordiyak:masterfrom
Open
Add autoCapitalize on textInput#51micheleantonazzi wants to merge 4 commits intomaxkordiyak:masterfrom
micheleantonazzi wants to merge 4 commits intomaxkordiyak:masterfrom
Conversation
rahombus97
reviewed
May 21, 2020
components/Autocomplete/index.js
Outdated
| this.setState({inputValue: ""}); | ||
| } else { | ||
| const capitalizedValue = capitalizeFirstLetter(valueExtractor(value)); | ||
| const capitalizedValue = this.props.firstLetterCapital === true ? capitalizeFirstLetter(valueExtractor(value)) : valueExtractor(value); |
There was a problem hiding this comment.
Would be cleaning to just do this.props.firstLetterCapital for the conditional
Author
There was a problem hiding this comment.
You're right. I'm implementing your suggestion, thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am using this plugin in my application and find it very useful and well done.
I have to set autoCapitalize to "none", but this possibility doesn't currently exist.
I modified the code to do this.
I hope it is appreciated