feat(Compression): Make BZip2 and LZ4 optional dependencies #13880
+150
−70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds CMake options to make BZip2 and LZ4 compression format support optional, reducing binary size and build complexity when these rarely-used formats are not needed in the drone ecosystem.
Changes:
- Added
QGC_ENABLE_BZIP2andQGC_ENABLE_LZ4CMake options (both default to OFF) - Modified build system to conditionally include BZip2 and LZ4 dependencies and configure libarchive accordingly
- Updated unit tests with conditional compilation guards to skip BZip2/LZ4 tests when disabled
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
cmake/CustomOptions.cmake |
Adds two new CMake options for optional BZip2 and LZ4 support with clear documentation |
src/Utilities/Compression/CMakeLists.txt |
Conditionally includes BZip2/LZ4 packages, configures libarchive with optional format support, adds compile definitions, and fixes xz test pollution |
test/Utilities/Compression/CMakeLists.txt |
Conditionally includes BZip2/LZ4 test resource files based on enabled options |
test/Utilities/Compression/QGCCompressionTest.cc |
Guards BZip2/LZ4 test cases with preprocessor directives, changes static arrays to vectors for conditional initialization |
test/Utilities/Compression/QGCStreamingDecompressionTest.cc |
Guards BZip2/LZ4 format entries with preprocessor directives in format test list |
HTRamsey
force-pushed
the
feature/optional-compression-formats
branch
from
cdc1a4f to
917925f
Compare
Contributor
Build ResultsPlatform Status
All builds passed. Test Resultslinux_gcc_64: 479 passed, 0 skipped Total: 479 passed, 0 skipped Code CoverageCoverage: 100.0% No baseline available for comparison Artifact Sizes
No baseline available for comparisonUpdated: 2026-01-21 01:58:35 UTC • Triggered by: Android |
HTRamsey
force-pushed
the
feature/optional-compression-formats
branch
2 times, most recently
from
5139376 to
ce8163d
Compare
Add CMake options QGC_ENABLE_BZIP2 and QGC_ENABLE_LZ4 (both OFF by default) to control whether these compression formats are built. Core formats (ZIP, GZIP, XZ/LZMA, ZSTD) remain always enabled. This reduces binary size and build dependencies for users who don't need these less common formats. Also set POSIX_REGEX_LIB=LIBC for libarchive to work around a CMake bug where ENABLE_LIBGCC=OFF causes a fatal error on Windows MSVC.
HTRamsey
force-pushed
the
feature/optional-compression-formats
branch
from
ce8163d to
d6bb743
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
QGC_ENABLE_BZIP2andQGC_ENABLE_LZ4(both default OFF) to optionally include these compression formatsChanges
cmake/CustomOptions.cmakesrc/Utilities/Compression/CMakeLists.txtQGC_ENABLE_BZIP2/QGC_ENABLE_LZ4compile definitions for C++ code#ifdefguards)BUILD_TESTING OFFUsage
To enable these optional formats:
Test plan
-DQGC_ENABLE_BZIP2=ON -DQGC_ENABLE_LZ4=ON- should succeed