Conversation
| API_BASE_URL = "https://" + API_BASE_HOST | ||
|
|
||
| ACCOUNT_SETTINGS_URL = API_BASE_URL + "/1.1/account/settings.json" | ||
| ACCOUNT_SETTINGS_URL = BASE_URL + "/i/api/1.1/account/settings.json" |
There was a problem hiding this comment.
This change looks wrong, official web client does this:
There was a problem hiding this comment.
For some reason even with the correct URL it wasn't working (404), apparently we were only using the ScreenName out of the result anyways, so replaced it with a proper user profile API fetch, which also fixes issues related to user profile info not updating.
There was a problem hiding this comment.
The endpoint exists, but will throw a fake 404 if SignTransaction didn't work, which might cause random issues in other endpoints as well
There was a problem hiding this comment.
I've fixed the ondemand script parsing and tested with https://api.x.com/1.1/account/settings.json endpoint, it was successful.
I think we should keep using the new API to fetch the user profile though as we were only using the ScreenName, whereas the new API provides complete user profile info. LMK what do you think.
2 participants
This PR fixes improper code that did not use the proper
keyVersionfield to compare conversation key versions.It also adds the missing query parameter for
settings.jsonendpoint.