Make links clickable

[FliegendeWurst]

Makes navigation easier. No need to copy and paste links to the address bar.

[FliegendeWurst]

All fixed :)

[matze]

I like the idea but there can be implications on runtime, especially with very large files. On the one hand there is another allocation, on the other hand

the overall worst case time complexity for this routine is O(m * n^2)

But I will merge for now and wait for complaints later :-)

Thank you for your contribution 👍

[FliegendeWurst]

I like the idea but there can be implications on runtime, especially with very large files.

The regex runs per-line, so the impact will be limited. If you are worried about the allocation, I suppose it could be skipped if there are no matches.

This regex specifically has a static prefix http so it will run very quickly.

[matze]

Seeing the potential for wrong output, how about we take a step back and write a custom HTML generator based on the one that's used? This avoids extra allocations and hacks like the double post-processing.

[FliegendeWurst]

Thanks for the suggestion. I had a look and the Markdown highlighter actually colors URL already.
This is the rule used: https://github.com/sublimehq/Packages/blob/fa6b8629c95041bf262d4c1dab95c456a0530122/Markdown/Markdown.sublime-syntax#L672-L696
That can be referenced in an additional syntax set. I'll update the PR soon.

[FliegendeWurst]

This kills debug performance. We could use the trick from https://stackoverflow.com/questions/60751806/how-to-compile-some-dependencies-with-release but I don't know which dependency is the culprit.

[FliegendeWurst]

And it depends on yaml-rust which was promptly denied by CI :(

trishume/syntect#537

[matze]

I piggy-backed on your idea in c8585a5. It's less intrusive because the bat/two-face syntax already marks the links in a way that can be recognized and I vendor bits of syntect code to output the links right away. I acknowledged your work in the CHANGELOG.md which I hope is fine with you.