Remove unnecessary clone() and tokio::spawn_blocking

[MIvanchev]

No description provided.

[matze]

Why do you think it's unnecessary?

[MIvanchev]

It starts a task and blocks while it runs so I thought it's some kinda of a mistake or a left over.

[matze]

It's exactly the opposite. spawn_blocking takes synchronous code that would block the executor and make it async-aware by moving it onto a separate dedicated thread for CPU-bound work.

[MIvanchev]

But you then sync it back in so nothing is won or I'm understanding something very false?

[matze]

If you mean "sync it back" making it .await then no, that yields back to the executor and some other future or task can proceed. If we were to block the CPU and thus the executor when highlighting (which can be expensive) then no one else could make progress. This is a good article on that topic.

[MIvanchev]

Oh, ok, this is most probably entirely meaningless in that case :) Thanks!