Conversation
offa
commented
Oct 23, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #218 +/- ##
==========================================
+ Coverage 33.99% 34.36% +0.36%
==========================================
Files 52 50 -2
Lines 2271 2267 -4
Branches 336 340 +4
==========================================
+ Hits 772 779 +7
+ Misses 1419 1408 -11
Partials 80 80 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mattgodbolt
reviewed
Oct 23, 2025
offa
commented
Oct 23, 2025
| - name: Build | ||
| run: | | ||
| cmake . -Bbuild | ||
| cmake . -Bbuild -GNinja |
Collaborator
Author
There was a problem hiding this comment.
Not strictly related to this topic, but I forgot this for codeql in the previous PR. 🙈
Collaborator
Author
|
@mattgodbolt could you have a final look over the PR? |
mattgodbolt
approved these changes
Dec 11, 2025
| target_include_directories(Catch INTERFACE "${CMAKE_CURRENT_SOURCE_DIR}/catch") | ||
| Include(FetchContent) | ||
|
|
||
| FetchContent_Declare( |
Collaborator
Author
|
Now there are Debian repo issues – I'm on it … UpdateFixed by rerun 🤷 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There isn't much change on the code side, but Catch 3 is no longer header-only; it is now a static library.