[MM-60513] Import profile pictures from Slack. #57

wetneb · 2024-09-20T11:29:08Z

Summary

This makes it possible to import profile pictures from Slack.

The code expects a Slack zip archive produced by slack-advanced-exporter with the additional PR:
grundleborg/slack-advanced-exporter#37

Given that slack-advanced-exporter doesn't seem actively developed, I am not sure if the PR there has any chances of getting through, so which makes it unlikely that this PR can also get accepted.
For this reason, it's perhaps a better idea to do the downloading in mmetl directly…

Ticket Link

https://mattermost.atlassian.net/browse/MM-60513

Closes #53.

Closes mattermost#53. This expects a Slack zip archive produced by slack-advanced-exporter with the additional PR: grundleborg/slack-advanced-exporter#37

fmartingr

This LGTM.

commands/transform.go

wetneb · 2024-10-16T12:00:53Z

Thanks for the review!

In case this was unclear from my description above: the dump format which this PR expects is something that I made up.

It is generated by grundleborg/slack-advanced-exporter#37 but does not correspond (as far as I know) to anything produced by Slack itself. Slack just provides the URLs of the profile pictures without including them in the dump - at least for the dumps I could get generate myself.

So unless you are happy with documenting that mmetl expects a dump format computed by my fork of slack-advanced-exporter, I would recommend against merging this as it stands. So it's worth reconsidering whether it wouldn't be okay for mmetl to do the downloading of the images itself, and the broader relationship to slack-advanced-exporter given that it's unmaintained and still referenced in the migration docs.

Marking the PR as draft to make this clearer

mattermost-build · 2024-10-27T01:04:33Z

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

agnivade · 2024-12-10T05:24:14Z

ping @isacikgoz

isacikgoz · 2024-12-13T14:13:23Z

@wetneb I'd say let's document that for the profile pictures, they can use your fork of slack-advanced-exporter. Since it's a community driven project, it wouldn't do harm to use yours.

isacikgoz · 2024-12-13T14:14:58Z

commands/transform.go

 		}
 	}

+	if !skipAttachments {


We may want to activate this path only if the flag is set. (eg. --include-profile-pictures)

For consistency with the other flags I have introduced it as --skip-profile-pictures, with a default set to false.

wetneb · 2024-12-14T19:36:36Z

As you want. Once this is released, the docs to be updated are at https://docs.mattermost.com/onboard/migrate-from-slack.html.

Co-authored-by: Felipe Martin <812088+fmartingr@users.noreply.github.com>

isacikgoz

LGTM, thanks @wetneb

isacikgoz · 2024-12-19T21:24:08Z

As you want. Once this is released, the docs to be updated are at https://docs.mattermost.com/onboard/migrate-from-slack.html.

Feel free to get the PR ready, we can merge once a new version of mmetl gets published.

mattermost-build · 2024-12-30T01:05:53Z

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

Documents mattermost/mmetl#57.

wetneb · 2024-12-31T17:45:36Z

I have opened a PR to update the docs here: mattermost/docs#7674

mattermost-build · 2025-01-18T01:06:36Z

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

mattermost-build · 2025-03-04T01:06:06Z

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

agnivade · 2025-03-04T03:57:38Z

@isacikgoz , @fmartingr - Is this ready to merge?

lieut-data · 2025-07-22T12:47:29Z

/update-branch

lieut-data · 2025-07-22T12:48:17Z

@DHaussermann, not urgent, but are you able to take a look at this for merging?

…performance optimizations - Merged upstream PR mattermost#57 which adds --skip-profile-pictures flag - Preserved our critical performance optimizations (single-pass user mention conversion) - Kept stdout logging for better visibility - Profile pictures now imported from exports when available

wetneb mentioned this pull request Sep 20, 2024

Move slack advanced exporter into the mmetl tool #40

Open

hanzei added the 2: Dev Review Requires review by a core committer label Oct 14, 2024

hanzei requested review from fmartingr and isacikgoz October 14, 2024 10:27

isacikgoz changed the title ~~Import profile pictures from Slack.~~ [MM-60513] Import profile pictures from Slack. Oct 15, 2024

Import profile pictures from Slack.

956b26f

Closes mattermost#53. This expects a Slack zip archive produced by slack-advanced-exporter with the additional PR: grundleborg/slack-advanced-exporter#37

wetneb force-pushed the import_profile_pictures branch from dbfae1d to 956b26f Compare October 15, 2024 13:21

fmartingr approved these changes Oct 16, 2024

View reviewed changes

commands/transform.go Outdated Show resolved Hide resolved

wetneb marked this pull request as draft October 16, 2024 12:00

mattermost-build added the Lifecycle/1:stale label Oct 27, 2024

isacikgoz reviewed Dec 13, 2024

View reviewed changes

isacikgoz removed the Lifecycle/1:stale label Dec 13, 2024

isacikgoz self-requested a review December 13, 2024 14:15

wetneb marked this pull request as ready for review December 14, 2024 19:25

Introduce --skip-profile-pictures

fdb7f68

wetneb force-pushed the import_profile_pictures branch from 332b07f to fdb7f68 Compare December 14, 2024 19:35

Update commands/transform.go

91442cc

Co-authored-by: Felipe Martin <812088+fmartingr@users.noreply.github.com>

isacikgoz approved these changes Dec 19, 2024

View reviewed changes

isacikgoz added 3: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Dec 19, 2024

mattermost-build added the Lifecycle/1:stale label Dec 30, 2024

wetneb added a commit to wetneb/docs that referenced this pull request Dec 31, 2024

Update migrate-from-slack.rst to include profile pictures

13bdfc8

Documents mattermost/mmetl#57.

wetneb mentioned this pull request Dec 31, 2024

Update migrate-from-slack.rst to include profile pictures mattermost/docs#7674

Closed

fmartingr removed the Lifecycle/1:stale label Jan 7, 2025

fmartingr requested a review from isacikgoz January 7, 2025 16:57

mattermost-build added the Lifecycle/1:stale label Jan 18, 2025

fmartingr removed the Lifecycle/1:stale label Feb 21, 2025

isacikgoz approved these changes Feb 21, 2025

View reviewed changes

mattermost-build added the Lifecycle/1:stale label Mar 4, 2025

Merge branch 'master' into import_profile_pictures

00571a3

lieut-data requested a review from DHaussermann July 22, 2025 12:47

lieut-data added Lifecycle/frozen 2: QA Review Requires review by a QA tester and removed Lifecycle/1:stale labels Jul 22, 2025

[MM-60513] Import profile pictures from Slack. #57

Are you sure you want to change the base?

[MM-60513] Import profile pictures from Slack. #57

Conversation

wetneb commented Sep 20, 2024 • edited by isacikgoz Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Ticket Link

Uh oh!

fmartingr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

wetneb commented Oct 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mattermost-build commented Oct 27, 2024

Uh oh!

agnivade commented Dec 10, 2024

Uh oh!

isacikgoz commented Dec 13, 2024

Uh oh!

isacikgoz Dec 13, 2024

Choose a reason for hiding this comment

Uh oh!

wetneb Dec 14, 2024

Choose a reason for hiding this comment

Uh oh!

wetneb commented Dec 14, 2024

Uh oh!

isacikgoz left a comment

Choose a reason for hiding this comment

Uh oh!

isacikgoz commented Dec 19, 2024

Uh oh!

mattermost-build commented Dec 30, 2024

Uh oh!

wetneb commented Dec 31, 2024

Uh oh!

mattermost-build commented Jan 18, 2025

Uh oh!

mattermost-build commented Mar 4, 2025

Uh oh!

agnivade commented Mar 4, 2025

Uh oh!

lieut-data commented Jul 22, 2025

Uh oh!

lieut-data commented Jul 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

wetneb commented Sep 20, 2024 •

edited by isacikgoz

Loading

wetneb commented Oct 16, 2024 •

edited

Loading