Skip to content

Conversation

@PhilippvK
Copy link
Collaborator

If an operand is missing in the ins field the tablegen backend will fail. Let's avoid this kind of errors by not generating a Pattern in this case.

This can patten when using --no-extend which leads to most operands being optimized away. The generated pattern (GPR:$rs1) would be invalid anyway, so we should not generate it.

@PhilippvK PhilippvK requested a review from mathis-s March 14, 2025 12:39
@PhilippvK PhilippvK self-assigned this Mar 14, 2025
@PhilippvK
Copy link
Collaborator Author

To address #50 I will also add checks to verify if the IN/OUT fields match the CDSLInst struct.

@mathis-s mathis-s marked this pull request as ready for review March 20, 2025 11:40
@PhilippvK PhilippvK merged commit bf17039 into mathis-s:llvm-19.1.0 Mar 21, 2025
4 checks passed
@PhilippvK PhilippvK deleted the detect-unused-ops branch March 21, 2025 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants