feat(mutils): Add workspace-id persistence across Auto Compact#20
Merged
feat(mutils): Add workspace-id persistence across Auto Compact#20
Conversation
- Rename session-id to workspace-id to avoid confusion with Claude Code's internal session_id - Add DB persistence in generate.ts for workspace-id - Add workspace-id-persist.ts hook for SessionStart (compact/resume) - Update ccs-handoff to use workspace-id - Update project-context.md with workspace-id terminology Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
4 tasks
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughMigrates mutils from session-id to workspace-id: adds workspace-id spec, validation, generator, and persistence hook; replaces session paths/usages with workspace equivalents; removes session-id hook; and bumps plugin version to 0.14.0. Changes
Sequence Diagram(s)sequenceDiagram
participant Claude as Claude (agent)
participant Hook as workspace-id-persist.ts
participant DB as MutilsDB
participant FS as Git + .agents
rect rgba(200,230,255,0.5)
Claude->>Hook: SessionStart event (source: compact/resume)
end
Hook->>FS: locate Git root and check `.agents` exists
FS-->>Hook: .agents present
Hook->>DB: query latest workspace_mappings
DB-->>Hook: returns latest mapping (workspace_id)
Hook->>Claude: respond with JSON context including `.agents/workspaces/{workspace_id}/`
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The hook was renamed to workspace-id-persist.ts. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
plugins/mutils/skills/ccs-handoff/ccs-handoff.ts (1)
457-493:⚠️ Potential issue | 🟠 MajorComplete the workspace-id migration in handoff output.
Extraction now reads from
.agents/workspaces, but the markdown still instructs session-id semantics (e.g., Line 592 uses.agents/sessions/...). This will guide users to the wrong path.🔧 Proposed fix
-interface UserSessionId { +interface UserWorkspaceId { fullId: string; featureName: string; } -function extractUserSessionId(projectPath: string): UserSessionId | null { +function extractUserWorkspaceId(projectPath: string): UserWorkspaceId | null { const workspacesDir = path.join(projectPath, ".agents", "workspaces"); // ... } function formatMarkdown( info: SessionInfo, messages: ParsedMessage[], jsonlSummary: string | null, tasks: PendingTask[], todos: PendingTodo[], hasSubagents: boolean, planFiles: string[], - userSessionId: UserSessionId | null, + userWorkspaceId: UserWorkspaceId | null, ): string { // ... - lines.push("## User Session ID"); + lines.push("## Workspace ID"); lines.push(""); - if (userSessionId) { - lines.push(`**Session ID**: \`${userSessionId.fullId}\``); + if (userWorkspaceId) { + lines.push(`**Workspace ID**: \`${userWorkspaceId.fullId}\``); lines.push(""); - lines.push(`**Feature Name**: ${userSessionId.featureName}`); + lines.push(`**Feature Name**: ${userWorkspaceId.featureName}`); lines.push(""); - lines.push("To continue using this session-id, create the session directory:"); + lines.push("To continue, use this workspace directory:"); lines.push(""); lines.push("```bash"); - lines.push(`mkdir -p .agents/sessions/${userSessionId.fullId}`); + lines.push(`mkdir -p .agents/workspaces/${userWorkspaceId.fullId}`); lines.push("```"); } else { - lines.push("No user session-id found in .agents/sessions/"); + lines.push("No workspace-id found in .agents/workspaces/"); } } -const userSessionId = sessionInfo.projectPath - ? extractUserSessionId(sessionInfo.projectPath) +const userWorkspaceId = sessionInfo.projectPath + ? extractUserWorkspaceId(sessionInfo.projectPath) : null; // ... - userSessionId, + userWorkspaceId,Also applies to: 579-596, 687-700
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@plugins/mutils/skills/ccs-handoff/ccs-handoff.ts` around lines 457 - 493, The handoff output still references ".agents/sessions" and uses names like userSessionId even though extraction now reads from ".agents/workspaces"; update the function and call-sites to reflect workspace semantics: rename or duplicate extractUserSessionId to extractUserWorkspaceId (and update its internal behavior if needed) and replace all uses of userSessionId with userWorkspaceId; change any generated markdown lines that do mkdir -p .agents/sessions/${...} to mkdir -p .agents/workspaces/${userWorkspaceId.fullId} and update the "No user session-id found" message to "No workspace-id found in .agents/workspaces/"; apply these renames/strings consistently for the other occurrences mentioned (the later handoff output blocks) and ensure parseWorkspaceId and returned fields (fullId, featureName) are used with the new variable names.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@plugins/mutils/skills/workspace-id/generate.ts`:
- Around line 31-33: The code currently silently skips persistence when the
.agents directory is missing or a DB write fails (in the block guarded by
gitRoot and agentsDir in generate.ts), so update the logic in the function that
generates the workspace id to detect and surface these failures: if
existsSync(agentsDir) is false, log an explicit error or throw (using the
existing logger like processLogger or by rejecting the promise) instead of
silently continuing; likewise wrap the DB write/save call (the persistence
routine inside the 35-60 region) with try/catch and on any error log the
detailed error and propagate it (throw or return a non-success result) so
generation does not report success while persistence failed. Ensure you
reference and update the agentsDir check and the DB write/save method so callers
can handle failure and restoration will not fail silently.
---
Outside diff comments:
In `@plugins/mutils/skills/ccs-handoff/ccs-handoff.ts`:
- Around line 457-493: The handoff output still references ".agents/sessions"
and uses names like userSessionId even though extraction now reads from
".agents/workspaces"; update the function and call-sites to reflect workspace
semantics: rename or duplicate extractUserSessionId to extractUserWorkspaceId
(and update its internal behavior if needed) and replace all uses of
userSessionId with userWorkspaceId; change any generated markdown lines that do
mkdir -p .agents/sessions/${...} to mkdir -p
.agents/workspaces/${userWorkspaceId.fullId} and update the "No user session-id
found" message to "No workspace-id found in .agents/workspaces/"; apply these
renames/strings consistently for the other occurrences mentioned (the later
handoff output blocks) and ensure parseWorkspaceId and returned fields (fullId,
featureName) are used with the new variable names.
ℹ️ Review info
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (9)
.claude-plugin/marketplace.json.claude/rules/ai-generated/project-context.mdplugins/mutils/hooks/hooks.jsonplugins/mutils/hooks/workspace-id-persist.tsplugins/mutils/plugin.jsonplugins/mutils/skills/ccs-handoff/ccs-handoff.tsplugins/mutils/skills/workspace-id/SKILL.mdplugins/mutils/skills/workspace-id/generate.tsplugins/mutils/skills/workspace-id/patterns.ts
Comment on lines
+31
to
+33
| if (gitRoot) { | ||
| const agentsDir = path.join(gitRoot, ".agents"); | ||
| if (existsSync(agentsDir)) { |
There was a problem hiding this comment.
Avoid silent persistence failure paths.
If .agents is missing or DB write fails, persistence can be skipped without any signal. That makes restore behavior fail silently even though generation “succeeds”.
🔧 Proposed fix
-import { existsSync } from "node:fs";
+import { mkdirSync } from "node:fs";
import path from "node:path";
import { findGitRoot, MutilsDB } from "@r_masseater/cc-plugin-lib";
import { isValidFeatureName } from "./patterns.js";
// ...
if (gitRoot) {
- const agentsDir = path.join(gitRoot, ".agents");
- if (existsSync(agentsDir)) {
- try {
- using db = MutilsDB.open(gitRoot);
- const table = db.table<{
- workspace_id: string;
- feature_name: string;
- created_at: string;
- }>("workspace_mappings", {
- columns: `
- id INTEGER PRIMARY KEY AUTOINCREMENT,
- workspace_id TEXT NOT NULL UNIQUE,
- feature_name TEXT NOT NULL,
- created_at TEXT NOT NULL
- `,
- indexes: [
- "CREATE UNIQUE INDEX IF NOT EXISTS idx_workspace_mappings_workspace_id ON workspace_mappings(workspace_id)",
- ],
- });
-
- const timestamp = now.toISOString();
- table.upsert({
- workspace_id: workspaceId,
- feature_name: featureName,
- created_at: timestamp,
- });
- } catch {
- // Fail silently - workspace-id generation should still work
- }
- }
+ try {
+ mkdirSync(path.join(gitRoot, ".agents", "mutils"), { recursive: true });
+ using db = MutilsDB.open(gitRoot);
+ const table = db.table<{
+ workspace_id: string;
+ feature_name: string;
+ created_at: string;
+ }>("workspace_mappings", {
+ columns: `
+ id INTEGER PRIMARY KEY AUTOINCREMENT,
+ workspace_id TEXT NOT NULL UNIQUE,
+ feature_name TEXT NOT NULL,
+ created_at TEXT NOT NULL
+ `,
+ indexes: [
+ "CREATE UNIQUE INDEX IF NOT EXISTS idx_workspace_mappings_workspace_id ON workspace_mappings(workspace_id)",
+ ],
+ });
+
+ const timestamp = now.toISOString();
+ table.upsert({
+ workspace_id: workspaceId,
+ feature_name: featureName,
+ created_at: timestamp,
+ });
+ } catch (error) {
+ process.stderr.write(
+ `Warning: failed to persist workspace-id: ${error instanceof Error ? error.message : String(error)}\n`,
+ );
+ }
}Also applies to: 35-60
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@plugins/mutils/skills/workspace-id/generate.ts` around lines 31 - 33, The
code currently silently skips persistence when the .agents directory is missing
or a DB write fails (in the block guarded by gitRoot and agentsDir in
generate.ts), so update the logic in the function that generates the workspace
id to detect and surface these failures: if existsSync(agentsDir) is false, log
an explicit error or throw (using the existing logger like processLogger or by
rejecting the promise) instead of silently continuing; likewise wrap the DB
write/save call (the persistence routine inside the 35-60 region) with try/catch
and on any error log the detailed error and propagate it (throw or return a
non-success result) so generation does not report success while persistence
failed. Ensure you reference and update the agentsDir check and the DB
write/save method so callers can handle failure and restoration will not fail
silently.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.agents/mutils/mutils.db)Changes
Architecture Simplification
session_idNew Files
plugins/mutils/skills/workspace-id/generate.ts- Generates and persists workspace-idplugins/mutils/skills/workspace-id/patterns.ts- Shared regex patternsplugins/mutils/skills/workspace-id/SKILL.md- Skill documentationplugins/mutils/hooks/workspace-id-persist.ts- SessionStart hook for restorationModified Files
plugins/mutils/hooks/hooks.json- Updated hooks configurationplugins/mutils/skills/ccs-handoff/ccs-handoff.ts- Updated to use workspace-id.claude/rules/ai-generated/project-context.md- Updated terminologyTest plan
bun run checkin plugins/mutilsbun run typecheckin plugins/mutils./plugins/mutils/skills/workspace-id/generate.ts test-feature.agents/mutils/mutils.db🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
Documentation
Chores