Proof of Concept: Test one function using testy#20
Open
linus wants to merge 1 commit intomarkusn:masterfrom
Open
Proof of Concept: Test one function using testy#20linus wants to merge 1 commit intomarkusn:masterfrom
linus wants to merge 1 commit intomarkusn:masterfrom
Conversation
This is just a PoC to show the feasability of doctest:ing the JSDoc @examples instead of / in addition to other tests. Because of require/import discrepancies, the test scaffolding needs some import shenanigans. Apart from that, the rounding needs to be handled somewhat differently. This could be solved in other ways, if given a feature request to testy: - One could imagine the option to inject different expect-logic in the test suite (make expect behave more fuzzy). - Or, the option of injecting a helper function to use in @examples. - ... or other options. In anticipation of a more thorough effort, though, it seems pertinent to update and modernize the project first, though. Nice library! 🙌
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just a PoC to show the feasability of doctest:ing the JSDoc
@examples instead of / in addition to other tests.
Because of require/import discrepancies, the test scaffolding needs
some import shenanigans.
Apart from that, the rounding needs to be handled somewhat differently.
This could be solved in other ways, if given a feature request to testy:
test suite (make expect behave more fuzzy).
In anticipation of a more thorough effort, though, it seems pertinent
to update and modernize the project first, though.
Nice library! 🙌