Fix null check logic in JsonMapConverter.mapToJson method #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The null check condition was inverted - it was throwing an exception when the map was NOT null instead of when it WAS null. Changed the condition from "if (map != null)" to "if (map == null)" on line 40. This fixes all failing tests in JsonMapConverterTest: - testMapToJson_SimpleMap - testMapToJson_NestedMap - testMapToJson_EmptyMap - testMapToJson_NullInput - testRoundTrip_JsonToMapToJson Resolves #7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the inverted null check condition in the
JsonMapConverter.mapToJson()method that was causing all tests to fail.Problem
The null check on line 40 was incorrectly checking
if (map != null)and throwing an exception when a non-null map was passed. This caused the method to:Solution
Changed the condition from
if (map != null)toif (map == null)on line 40.Tests Fixed
This fixes all failing tests in
JsonMapConverterTest:testMapToJson_SimpleMaptestMapToJson_NestedMaptestMapToJson_EmptyMaptestMapToJson_NullInputtestRoundTrip_JsonToMapToJsonCloses #7