Fix failing tests in JsonMapConverter - Issue #30 #31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the failing JUnit tests in
JsonMapConverterTestby correcting an inverted null check condition in themapToJsonmethod.Problem
The
mapToJsonmethod inJsonMapConverter.javahad a logic error on line 42:This condition was backwards - it was throwing an exception when the map was not null, which caused all tests that passed valid maps to fail.
Solution
Changed the condition to correctly check for null:
Tests Affected
This fix resolves the following failing tests:
testMapToJson_SimpleMaptestMapToJson_NestedMaptestMapToJson_EmptyMaptestMapToJson_NullInputtestRoundTrip_JsonToMapToJsonAll tests should now pass successfully.
Fixes #30