Fix issue #27: Correct inverted null check in mapToJson method #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed inverted null check condition in mapToJson method. The method was throwing IllegalArgumentException when map was NOT null, instead of when map was null. Changed condition from 'if (map != null)' to 'if (map == null)' to properly validate input. This fix resolves failing tests: - testMapToJson_NullInput - testMapToJson_NestedMap - testMapToJson_EmptyMap - testRoundTrip_JsonToMapToJson
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed the inverted null check condition in the
mapToJsonmethod that was causing test failures.Problem
The
mapToJsonmethod inJsonMapConverter.javahad an inverted null check on line 40:This caused the method to throw an
IllegalArgumentExceptionwhen the map was NOT null, which is the opposite of the intended behavior.Solution
Changed the condition from
if (map != null)toif (map == null)to properly validate the input parameter.Tests Fixed
This fix resolves the following failing tests:
testMapToJson_NullInputtestMapToJson_NestedMaptestMapToJson_EmptyMaptestRoundTrip_JsonToMapToJsonChanges
code/src/main/java/org/example/util/JsonMapConverter.java: Fixed null check condition on line 40Closes #27