Fix null check logic in mapToJson method #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The condition on line 41 was incorrectly checking if (map != null) when it should check if (map == null). This caused the method to throw an exception when a valid map was provided, instead of when a null map was provided. Fixes #18
Owner
Author
|
Please fill the body of the Pull Request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the failing tests in
JsonMapConverterTestby correcting a logic error in themapToJsonmethod.Problem
The tests were failing because the null check on line 41 of
JsonMapConverter.javawas inverted:if (map != null)- This threw an exception when a VALID map was providedif (map == null)- This correctly throws an exception when a NULL map is providedChanges
mapToJson()method fromif (map != null)toif (map == null)Test Results
This fix addresses all the failing tests mentioned in issue #18:
testMapToJson_SimpleMap- Now passes with valid map inputtestMapToJson_NestedMap- Now passes with valid map inputtestMapToJson_EmptyMap- Now passes with empty map inputtestMapToJson_NullInput- Now correctly throwsIllegalArgumentExceptionfor null inputtestRoundTrip_JsonToMapToJson- Now completes the round trip successfullyFixes #18