Fix: Correct null check logic in JsonMapConverter.mapToJson() #19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the failing tests in
JsonMapConverterTestby correcting an inverted null check condition in themapToJson()method.Problem
The tests were failing because the
mapToJson()method at line 41 had an inverted condition:This caused the method to throw an
IllegalArgumentExceptionwhenever a valid (non-null) map was passed, which is the opposite of the intended behavior.Solution
Changed the condition from
if (map != null)toif (map == null)incode/src/main/java/org/example/util/JsonMapConverter.java:41Now the method correctly:
Tests Fixed
This fix resolves all failing tests in
JsonMapConverterTest:testMapToJson_SimpleMap()testMapToJson_EmptyMap()testMapToJson_NestedMap()testRoundTrip_JsonToMapToJson()Closes #18