Skip to content

Make it work with coconut.html.#3

Open
back2dos wants to merge 3 commits intomarkknol:masterfrom
back2dos:master
Open

Make it work with coconut.html.#3
back2dos wants to merge 3 commits intomarkknol:masterfrom
back2dos:master

Conversation

@back2dos
Copy link
Contributor

@back2dos back2dos commented May 5, 2020

First stab at rendering all views statically. Let's track all issues in this PR.

@markknol
Copy link
Owner

markknol commented May 5, 2020

I tried to change target:

interp

compile error: Field index for items not found on prototype bootstrap.ListGroup

PHP

runtime error:

Fatal error: Uncaught ErrorException: Undefined property: bootstrap\ListGroup::$items in c:\xyz\coconut.bootstrap\out\lib\bootstrap\ListGroup.php:198 Stack trace: #0 
c:\xyz\coconut.bootstrap\out\lib\bootstrap\ListGroup.php(198): php\Boot::php\{closure}(8, 'Undefined prope...', 'C:\\xyz\\...', 198, Array) #1 
[internal function]: bootstrap\ListGroup->render() #2 
c:\xyz\coconut.bootstrap\out\lib\php\_Boot\HxClosure.php(67): call_user_func_array(Array, Array) #3 
c:\xyz\coconut.bootstrap\out\lib\coconut\html\View.php(151): php\_Boot\HxClosure->__invoke() #4 
c:\xyz\coconut.bootstrap\out\lib\php\_Boot\HxAnon.php(44): coconut\html\View->coconut\html\{closure}() #5 
c:\xyz\coconut.bootstrap\out\lib\tink\state\_Observable\AutoObservable.php(103): php\_Boot\HxAnon->__call('f', Array) #6 
c:\xyz\coconut.bootstrap\out\lib\tink\state\_Observabl in 
c:\xyz\coconut.bootstrap\out\lib\bootstrap\ListGroup.php on line 198

HashLink 1.11

Works!

back2dos added 2 commits May 5, 2020 13:20
… Conflicts:#	src/bootstrap/Button.hx#	src/bootstrap/Container.hx#	src/bootstrap/Dropdown.hx
@back2dos
Copy link
Contributor Author

back2dos commented May 5, 2020

Soo, the error was this: HaxeFoundation/haxe#9379

I've made the three render functions in ListGroup optional.

As a side note: if you give a body to an @:attribute function, it can never be null (which is kind of the point).

@markknol
Copy link
Owner

markknol commented May 5, 2020

Good to know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants