Fix primary_photo schema to accept both string and array #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Mapbox API sometimes returns primary_photo as a string and sometimes as an array of strings. Update the schema to accept both types using z.union() to prevent validation errors. Fixes validation error: Expected array, received string for features[].properties.metadata.primary_photo 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
Valiunia
approved these changes
Dec 11, 2025
mattpodwysocki
added a commit
that referenced
this pull request
Jan 5, 2026
The Mapbox Search Box API can return metadata (including primary_photo and Japanese reading information) for various feature types in forward geocoding results. Currently, SearchAndGeocodeTool.output.schema.ts doesn't include a metadata field, which could lead to validation errors when the API returns this data. This fix adds the metadata field with the same structure used in CategorySearchTool (fixed in PR #77): - primary_photo: Accepts both string and array of strings - reading: Optional Japanese reading information (ja_kana, ja_latin) This prevents validation failures when the API returns metadata fields. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
mattpodwysocki
added a commit
that referenced
this pull request
Jan 5, 2026
The Mapbox Search Box API can return metadata (including primary_photo and Japanese reading information) for various feature types in forward geocoding results. Currently, SearchAndGeocodeTool.output.schema.ts doesn't include a metadata field, which could lead to validation errors when the API returns this data. This fix adds the metadata field with the same structure used in CategorySearchTool (fixed in PR #77): - primary_photo: Accepts both string and array of strings - reading: Optional Japanese reading information (ja_kana, ja_latin) This prevents validation failures when the API returns metadata fields. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Sonnet 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Mapbox API sometimes returns primary_photo as a string and sometimes
as an array of strings. Update the schema to accept both types using
z.union() to prevent validation errors.
Fixes validation error: Expected array, received string for
features[].properties.metadata.primary_photo