Skip to content

Fix issue with referencing field in doubly-nested join inside a nest#2092

Merged
mtoy-googly-moogly merged 2 commits intomainfrom
crs-fix-double-nested-join-in-nest-reference
Jan 13, 2025
Merged

Fix issue with referencing field in doubly-nested join inside a nest#2092
mtoy-googly-moogly merged 2 commits intomainfrom
crs-fix-double-nested-join-in-nest-reference

Conversation

@christopherswenson
Copy link
Contributor

In this kind of construction:

source: a_2 is a extend { join_one: b is b extend {
  join_one: c is b on 1 = c.ai
} with astr }

run: a_2 -> {
  nest: x is {
    group_by: ai is b.c.ai
  }
}

I was computing the wrong join usage (which is used for the composite sources feature). Specifically, it was making it out that ai is b.c.ai used joins b.c as well as c (unqualified). Then when the nest was evaluated in the outer query, it tried to figure out what c was (unqualified), and that doesn't exist.

@mtoy-googly-moogly mtoy-googly-moogly merged commit b88762b into main Jan 13, 2025
15 checks passed
@mtoy-googly-moogly mtoy-googly-moogly deleted the crs-fix-double-nested-join-in-nest-reference branch January 13, 2025 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants