fix case where the nested field can have multiple types#2072
Closed
amitaggarwal1 wants to merge 5 commits intomalloydata:mainfrom
Closed
fix case where the nested field can have multiple types#2072amitaggarwal1 wants to merge 5 commits intomalloydata:mainfrom
amitaggarwal1 wants to merge 5 commits intomalloydata:mainfrom
Conversation
… 100 sample). In most cases, we should fail but in cases where the field types are integer and decimal we should not fail and make the field decimal. this can happen when there is a nested field and sometimes has a float value and sometimes an integer value
I, Amit Aggarwal <[email protected]>, hereby add my Signed-off-by to this commit: 323229d Signed-off-by: Amit Aggarwal <[email protected]>
Signed-off-by: Amit Aggarwal <[email protected]>
- make decimal and integer the same - ignore null values - remove any fields where there is conflicting types Signed-off-by: Amit Aggarwal <[email protected]>
Signed-off-by: Amit Aggarwal <[email protected]>
lloydtabb
added a commit
that referenced
this pull request
Jan 8, 2025
Collaborator
mtoy-googly-moogly
left a comment
mtoy-googly-moogly
left a comment
There was a problem hiding this comment.
Actually I need to think about this.
mtoy-googly-moogly
added a commit
that referenced
this pull request
Jan 11, 2025
* Add these changes from #2072 and #2074 * Need to also change the way arrays are unnested. * mtoy's take on the changes ... passes ci-snowflake * add fix and test for array names ending in numbers * Add changes from #2088 * delete line for linter --------- Co-authored-by: Michael Toy <[email protected]>
Collaborator
|
#2086 has these changes in it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix case where the nested field can have multiple types (based on the 100 sample).
In most cases, we should fail but in cases where the field types are integer and decimal we should not fail and make the field decimal. this can happen when there is a nested field and sometimes has a float value and sometimes an integer value