Fix Mac Silicon bug: service_manager.py incorrectly selects x64 binary on Apple Silicon Macs #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…logic Co-authored-by: vigneshc <[email protected]>
Fix Mac Silicon bug: service_manager.py incorrectly selects x64 binary on Apple Silicon Macs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ServiceManager.service_path() method had a logic bug that caused Mac computers with Apple Silicon (M1/M2/M3/M4) chips to incorrectly receive the x64 service binary instead of the arm64 binary. This would result in the wrong architecture binary being loaded, leading to potential crashes or failures.
The changes were done completely by github copilot in this PR.