Skip to content

fix: enforce multicastgroup ip allocate can't be called twice #2803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elitegreg merged 1 commit into from
Feb 3, 2026
Merged

fix: enforce multicastgroup ip allocate can't be called twice #2803

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 15 additions & 12 deletions smartcontract/programs/doublezero-serviceability/src/processors/multicastgroup/activate.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,18 +107,21 @@ pub fn process_activate_multicastgroup(
"Invalid ResourceExtension PDA for MulticastGroupBlock"
);

// Allocate from ResourceExtension bitmap
let mut buffer = resource_ext.data.borrow_mut();
let mut resource = ResourceExtensionBorrowed::inplace_from(&mut buffer[..])?;

let allocated = resource.allocate(1)?;

match allocated {
IdOrIp::Ip(network) => {
multicastgroup.multicast_ip = network.ip();
}
IdOrIp::Id(_) => {
return Err(DoubleZeroError::InvalidArgument.into());
// Allocate from ResourceExtension bitmap (only if not already allocated)
// This check handles potential re-activation scenarios where resources may already be assigned
if multicastgroup.multicast_ip == std::net::Ipv4Addr::UNSPECIFIED {
let mut buffer = resource_ext.data.borrow_mut();
let mut resource = ResourceExtensionBorrowed::inplace_from(&mut buffer[..])?;

let allocated = resource.allocate(1)?;

match allocated {
IdOrIp::Ip(network) => {
multicastgroup.multicast_ip = network.ip();
}
IdOrIp::Id(_) => {
return Err(DoubleZeroError::InvalidArgument.into());
}
}
}
} else {
Expand Down
Loading