Smartcontract: Add ResourceExtension and Foundation Commands for Managing #2377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elitegreg
force-pushed
the
gm/ip_allocation
branch
2 times, most recently
from
2531292 to
b010de7
Compare
elitegreg
force-pushed
the
gm/ip_allocation
branch
from
66a5e38 to
cb28d3e
Compare
elitegreg
changed the title
There was a problem hiding this comment.
Pull request overview
This PR implements ResourceExtension accounts for managing IP and ID allocations in the smart contract. It introduces a new on-chain account type with bitmap-based allocation tracking and provides Foundation-restricted CLI commands for resource management.
- Adds ResourceExtension account type with IpAllocator and IdAllocator for bitmap-based resource tracking
- Implements create/allocate/deallocate instructions with Foundation allowlist enforcement
- Adds CLI commands and SDK methods for resource management operations
Reviewed changes
Copilot reviewed 43 out of 44 changed files in this pull request and generated 19 comments.
Show a summary per file
| File | Description |
|---|---|
| smartcontract/programs/doublezero-serviceability/src/state/resource_extension.rs | Core ResourceExtension state implementation with owned and borrowed variants |
| smartcontract/programs/doublezero-serviceability/src/ip_allocator.rs | IP address allocation using bitmap for efficient subnet tracking |
| smartcontract/programs/doublezero-serviceability/src/id_allocator.rs | ID allocation using bitmap for numeric range tracking |
| smartcontract/programs/doublezero-serviceability/src/processors/resource/*.rs | Processor functions for create/allocate/deallocate operations |
| smartcontract/programs/doublezero-serviceability/tests/resource_extension_test.rs | Comprehensive integration tests for all ResourceType variants |
| smartcontract/sdk/rs/src/commands/resource/*.rs | SDK command implementations for resource operations |
| smartcontract/cli/src/resource/*.rs | CLI command implementations with validation |
| smartcontract/programs/doublezero-serviceability/src/pda.rs | PDA derivation functions for all ResourceType variants |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
smartcontract/programs/doublezero-serviceability/src/state/resource_extension.rs
Outdated
Show resolved
Hide resolved
smartcontract/programs/doublezero-serviceability/src/state/resource_extension.rs
Outdated
Show resolved
Hide resolved
smartcontract/programs/doublezero-serviceability/src/state/resource_extension.rs
Outdated
Show resolved
Hide resolved
smartcontract/programs/doublezero-serviceability/src/state/resource_extension.rs
Outdated
Show resolved
Hide resolved
smartcontract/programs/doublezero-serviceability/src/state/resource_extension.rs
Outdated
Show resolved
Hide resolved
elitegreg
commented
Dec 23, 2025
smartcontract/programs/doublezero-serviceability/src/processors/resource/allocate.rs
Outdated
Show resolved
Hide resolved
smartcontract/programs/doublezero-serviceability/src/processors/resource/create.rs
Outdated
Show resolved
Hide resolved
smartcontract/programs/doublezero-serviceability/src/processors/resource/deallocate.rs
Outdated
Show resolved
Hide resolved
- Add integration tests covering CreateResource, AllocateResource, and DeallocateResource instructions - Add test helpers: get_resource_extension_data, wait_for_new_blockhash, setup_program_with_globalconfig - Add get_resource_extension() getter to AccountData - Fix test_allocation_prefix_range_check: use correct allocation_size values to trigger validation errors Covering: - Happy path: create, allocate, deallocate, full lifecycle - Security: foundation_allowlist enforcement - Errors: double allocation, duplicate create, nonexistent resource - DzPrefixBlock: device-specific allocation and PDA derivation
elitegreg
force-pushed
the
gm/ip_allocation
branch
from
161bb5b to
b64d2f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Testing Verification
Closes #2386
Closes #2387
Closes #2389
Closes #2390
Closes #2392
Closes #2393
Closes #2394
Closes #2395
Closes #2396
Closes #2397
Closes #2399