feat: Add support for Tion Breezer Bio X (9mqdhwklpvnnvb7t)#4137
feat: Add support for Tion Breezer Bio X (9mqdhwklpvnnvb7t)#4137levikinva wants to merge 4 commits intomake-all:mainfrom
Conversation
levikinva
force-pushed
the
add-tion-breezer-bio-x
branch
4 times, most recently
from
0d3448a to
c2a2317
Compare
levikinva
force-pushed
the
add-tion-breezer-bio-x
branch
from
c2a2317 to
56248f3
Compare
| @@ -0,0 +1,237 @@ | |||
| name: Tion Breezer Bio X | |||
There was a problem hiding this comment.
Branding should be in the products section (as manufacturer and model tags).
Top level name should be generic in case of other devices matching the same config.
| - id: 9mqdhwklpvnnvb7t | ||
| entities: | ||
| # Main entities | ||
| - entity: switch |
There was a problem hiding this comment.
I think this device should be a higher level type of device, maybe climate since it has temperature control also.
There was a problem hiding this comment.
I tried the climate implementation, but found it misleading. It implies the device can control the room's temperature, which it cannot; it only heats the incoming air. This is a secondary function, as the device's main purpose is ventilation.
| type: integer | ||
| unit: "%" | ||
| - entity: sensor | ||
| name: "CO2" |
There was a problem hiding this comment.
sensors with classes should not need names that are essentially the same as the class.
| name: switch | ||
| type: boolean | ||
| - entity: switch | ||
| name: "Child Lock" |
There was a problem hiding this comment.
Standard pattern is to use a lock entity for this:
- entity: lock
translation_key: child_lock
category: config
dps:
- id: 111
type: boolean
name: lock
|
|
||
| # Configuration entities | ||
| - entity: switch | ||
| name: "Night Mode" |
There was a problem hiding this comment.
I think translaton_key: sleep can be used here instead of this name and icon
| - id: 111 | ||
| name: switch | ||
| type: boolean | ||
| - entity: select |
There was a problem hiding this comment.
This should be a light entity, with dp name brightness, and values mapped to 0, 128, 255
| name: switch | ||
| type: boolean | ||
| - entity: switch | ||
| name: "Filter Reset" |
There was a problem hiding this comment.
Should be a button entity, with translation_key: filter_reset
| type: integer | ||
| unit: "°C" | ||
| - entity: sensor | ||
| name: "Outdoor Temperature" |
There was a problem hiding this comment.
HA naming convention is to only capitalise the first word of entity and device names (unless abbreviations or branding is involved)
|
|
||
| # Diagnostic entities | ||
| - entity: sensor | ||
| name: "Heater Type" |
There was a problem hiding this comment.
This will never change, so probably not useful as a sensor. May be an attribute on another entity, especially if the value can be used to selectively enable features.
There was a problem hiding this comment.
This is diagnostic information about the device's heater type. I couldn't find a suitable way to display it as a static label. It's included with hidden: true for completeness. This value is purely informational and cannot be used to enable or disable any device function, as all device configurations come with a heater.
| name: sensor | ||
| type: string | ||
| - entity: sensor | ||
| name: "CO2 Sensor Status" |
There was a problem hiding this comment.
should maybe just be an attribute of the CO2 sensor. Especially if it is just indicating whether the sensor is fitted or not, in which case it can be the available attribute with a mapping to true/false depending on value.
|
@make-all Please review |
make-all
added
the
sanctioned
(cherry picked / squashed from upstream PR make-all#4137)
(cherry picked / squashed from upstream PR make-all#4137)
2 participants
Device: Tion Breezer Bio X
Product ID: 9mqdhwklpvnnvb7t
Link to product: https://tion.kz/product/breezer-tion-bio-x/