Loosen requirement for faraday multipart - Support Ruby 4.0#372
Merged
alex-leb merged 7 commits intomailgun:masterfrom Dec 28, 2025
Merged
Loosen requirement for faraday multipart - Support Ruby 4.0#372alex-leb merged 7 commits intomailgun:masterfrom
alex-leb merged 7 commits intomailgun:masterfrom
Conversation
Contributor
Author
|
@alex-leb OpenStruct is not needed. Newer rake version is though (since rake 13.2.0 replaced it - and this gem also removed usage in 1.2.15). Can you approve workflow runs again? I have green specs locally now, with updated rake, and VCR (Dev dependencies all updated, basically) |
Contributor
|
Thanks @frederikspang. It fails for 2.6 and 2.7. Let's check if we can fix it. If not, I can deprecate these versions in Mailgun v1.4.1. |
Contributor
|
rspec-its 2.0.0 REQUIRED RUBY VERSION:
I'll deprecate Ruby versions 2.6 and 2.7 starting from the next release. |
Contributor
|
Great Work @frederikspang! Thanks! |
Contributor
Author
|
2.6/2.7 are EOL a few years ago. We could easily maintain compatibility - I don't Think rspec-its gem is in use. Could just be removed from gemspec. @alex-leb |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looser requirement, to allow 1.x to be installed.
Has the side effect of Ruby 4.0 support.