Skip to content

Conversation

@mahkoh
Copy link
Owner

@mahkoh mahkoh commented Oct 22, 2025

No description provided.

@mahkoh mahkoh requested a review from Copilot October 22, 2025 19:10
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR extends the XKB configuration parser to allow keysyms in interpret statements to be specified as integer literals (e.g., 0x61) in addition to the existing identifier and string formats.

Key Changes:

  • Added Integer(Interned, i64) variant to the InterpretSym enum
  • Updated parser, resolver, and formatter to handle integer keysym specifications
  • Added test case demonstrating interpret statements with hexadecimal integer keysyms

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
kbvm/src/xkb/kccgst/ast.rs Adds Integer variant to InterpretSym enum to represent integer keysyms
kbvm/src/xkb/kccgst/parser.rs Extends parser to recognize Token::Integer as valid interpret statement keysym
kbvm/src/xkb/kccgst/resolver.rs Maps InterpretSym::Integer to Expr::Integer for keysym evaluation
kbvm/src/xkb/kccgst/formatter.rs Implements formatting for integer keysyms by writing the interned representation
compile-tests/testcases/t04/t049/t0494/input.xkb Test input demonstrating integer keysym syntax (0x61, 0x62) in interpret statements
compile-tests/testcases/t04/t049/t0494/expected.xkb Expected output showing interpret statements are processed correctly with integer keysyms

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@mahkoh mahkoh force-pushed the jorth/interpret-keysym-integer branch from 82bdc2c to 7c2e626 Compare October 23, 2025 23:01
@mahkoh mahkoh merged commit 0be39be into master Oct 23, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants