Skip to content

Conversation

@mahkoh
Copy link
Owner

@mahkoh mahkoh commented Oct 15, 2025

No description provided.

@mahkoh mahkoh requested a review from Copilot October 15, 2025 12:10
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds a new CLI subcommand to dump the current X11 keymap and refactors formatting options into a reusable struct.

  • Introduces DumpX11 subcommand to fetch and print the XKB keymap from the X server.
  • Extracts formatting-related flags into a new FormatArgs and updates existing compile commands to use it.
  • Adds x11rb dependency and enables kbvm's x11 feature.

Reviewed Changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
kbvm-cli/src/main.rs Registers the new dump_x11 module.
kbvm-cli/src/dump_x11.rs Implements the DumpX11 command: connects to X11, enables XKB, fetches the keymap, and prints it.
kbvm-cli/src/compile_xkb.rs Switches to FormatArgs for output formatting.
kbvm-cli/src/compile_rmlvo.rs Switches to FormatArgs for output formatting.
kbvm-cli/src/cli.rs Adds DumpX11 subcommand (unix-only) and introduces FormatArgs with an apply method.
kbvm-cli/Cargo.toml Adds x11rb dependency and kbvm x11 feature.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@mahkoh mahkoh requested a review from Copilot October 15, 2025 12:17
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 6 out of 7 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@mahkoh mahkoh merged commit ec293bd into master Oct 17, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants