Skip to content

Conversation

@mahkoh
Copy link
Owner

@mahkoh mahkoh commented Oct 9, 2025

No description provided.

@mahkoh mahkoh requested a review from Copilot October 9, 2025 18:27
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds CLI flags to control XKB keymap formatting behavior by introducing lookup-only and rename-long-names options to the compile commands.

  • Added lookup_only and rename_long_names boolean flags to CompileArgs
  • Created apply2 method to configure Formatter based on these flags
  • Updated compile functions to use the new formatter configuration

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
kbvm-cli/src/cli.rs Added new CLI flags and apply2 method to configure keymap formatter
kbvm-cli/src/compile_xkb.rs Updated to use configurable formatter instead of hardcoded settings
kbvm-cli/src/compile_rmlvo.rs Updated to use configurable formatter instead of hardcoded settings

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@mahkoh mahkoh merged commit ddf2298 into master Oct 9, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants