Add missing HTTP methods to Curl client (PUT, DELETE, PATCH, OPTIONS, HEAD, TRACE, CONNECT) #40392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add PUT, DELETE, PATCH, OPTIONS, HEAD, TRACE, and CONNECT methods to the Curl HTTP client class. These methods follow RFC 9110 standards for HTTP semantics and are essential for working with modern APIs. Changes: 1. Added HTTP_METHODS_WITH_PAYLOAD constant to identify methods that support request payloads (POST, PUT, PATCH, OPTIONS). 2. Implemented new public methods: - put(string $uri, string|array $params): void - delete(string $uri, array|string $params = []): void - patch(string $uri, array|string $params): void - options(string $uri, array|string $params = []): void - head(string $uri): void - trace(string $uri): void - connect(string $uri): void 3. Refactored makeRequest() to use switch statement for better method handling and to properly set CURLOPT_PUT for PUT requests. 4. Updated test framework Curl helper to match new delete() signature. 5. Added RFC references in docblocks for HTTP method specifications. This implementation: - Maintains backward compatibility with existing GET and POST methods - Follows HTTP RFC specifications (RFC 9110, RFC 5789) - Properly handles request payloads for all methods that support them - Uses CURLOPT_PUT for PUT requests and CURLOPT_CUSTOMREQUEST for others Fixes magento#40157
|
Hi @koushikch7. Thank you for your contribution!
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
Author
|
@magento run all tests |
Author
|
@magento run Functional Tests B2B,Semantic Version Checker |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #40157
Description
Adds support for missing HTTP methods in the Curl HTTP client implementation as per RFC 9110 (HTTP semantics) and RFC 5789 (PATCH method).
Methods Added
Changes
Testing
Related