[do not merge] On demand image download #14258
Open
+488
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds automatic downloading of missing card images when they are first displayed, eliminating the need for users to manually download all images upfront via the bulk download dialog. Features: - New OnDemandImageDownloader singleton service that downloads missing images in the background using Scryfall (normal quality) - Rate limiting (300ms between API calls) to respect Scryfall limits - Duplicate prevention - cards are only downloaded once per session - New preference checkbox "Download missing images automatically" in the Images tab (disabled by default, opt-in) When enabled, missing card images are queued for download when the ImageCache detects a cache miss. Images appear automatically once downloaded.
Card panels now register listeners with OnDemandImageDownloader to automatically refresh when their image is downloaded. Listener registration is gated by the auto-download preference setting.
Contributor
|
Thanks for working on this, great feature enhancement for the user experience |
JayDi85
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features
Test plan
Video in action
download-on-demand.mp4