[minor] Scryfall image adjustments #14166
Open
+19
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…resource heavy and modern hardware can handle it fine
Contributor
|
These are unrelated commits so if merged should not be squashed. Some notes:
|
JayDi85
requested changes
Jan 13, 2026
|
|
||
| static { | ||
| directLinks.put(cardbackFilename, "https://upload.wikimedia.org/wikipedia/en/a/aa/Magic_the_gathering-card_back.jpg"); | ||
| directLinks.put(cardbackFilename, "https://backs.scryfall.io/large/0/a/0aeebaf5-8c7d-4636-9e82-8c27447861f7.jpg"); |
Member
There was a problem hiding this comment.
Wrong, do not use any guid or io links -- it's cdn related and can be changed any time by scryfall. Only api links must be used.
|
|
||
| // DOWNLOAD THREADS | ||
| uiDialog.getDownloadThreadsCombo().setModel(new DefaultComboBoxModel<>(new String[]{"10", "9", "8", "7", "6", "5", "4", "3", "2", "1"})); | ||
| uiDialog.getDownloadThreadsCombo().setModel(new DefaultComboBoxModel<>(new String[]{"100", "75", "50", "40", "30", "20", "15", "10", "5", "1"})); |
Member
There was a problem hiding this comment.
No need such big values -- it can be unstable (zip storage mode easy to fail), also it can be banned by scryfall (it allow any rate limits on cdn/io links, but I don't trust it). So 1 - 20 are good.
| // TODO: can't find backface's api url so use direct link from third party site instead (must be replaced to scryfall someday) | ||
| res.add(createXmageToken(XMAGE_IMAGE_NAME_FACE_DOWN_MANUAL, 1, "https://upload.wikimedia.org/wikipedia/en/a/aa/Magic_the_gathering-card_back.jpg")); | ||
| // Can't find backface via the API, so use direct image link | ||
| res.add(createXmageToken(XMAGE_IMAGE_NAME_FACE_DOWN_MANUAL, 1, "https://backs.scryfall.io/large/0/a/0aeebaf5-8c7d-4636-9e82-8c27447861f7.jpg")); |
| // Helper emblem (for global card hints) | ||
| // use backface for it | ||
| res.add(createXmageToken(XMAGE_IMAGE_NAME_HELPER_EMBLEM, 1, "https://upload.wikimedia.org/wikipedia/en/a/aa/Magic_the_gathering-card_back.jpg")); | ||
| res.add(createXmageToken(XMAGE_IMAGE_NAME_HELPER_EMBLEM, 1, "https://backs.scryfall.io/large/0/a/0aeebaf5-8c7d-4636-9e82-8c27447861f7.jpg")); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handful of minor things;
backs.scryfall.io. You can pass in thecard_back_idto the URL which follows similar path conventions ascards.scryfall.io. This magic ID is the standard MTG card back, per their API.. Built a client locally and tested it renders correctly still.java:S2208which advises against wildcard imports.