Fix problem with unit tests and update jQuery dependency #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 16, 2015 09:35
At least on Debian, "open" is an alias for "openvt", which results in the error "Couldn't get a file descriptor referring to the console".
The version doesn't matter so much because it doesn't use much core functionality. Tests still all pass with latest jQuery 2.1.3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a jQuery version conflict in my application (which used jQuery 2.1) due to jquery-serialize-object having a hard dependency on jQuery 1.8. After updating the bower file and running the tests they all still pass. It seems that you're not using any particular jQuery features that have been changed, so I've just made the selector a lot less strict.
I also ran into a problem with npm: uglify-js 2.4.32 doesn't seem to exist, the latest published version I could find was 2.4.16.
To run the tests, I had to make another change because I got an obscure error message "Couldn't get a file descriptor referring to the console", which was due to the fact that under GNU/Linux (at least Debian and Ubuntu), "open" refers to "openvt", which requires a virtual terminal (on the physical console, so an xterm is not accepted). The fix is to use xdg-open. However, this may break the test runner on OS X, so perhaps some kind of dispatching script is a better solution. See
https://github.com/gfestari/explain_shell/commit/bbc2d2c9bd507127bfd8cb6b67ef6a0151a5749b for example.