Skip to content

Conversation

@denischilik
Copy link
Contributor

@denischilik denischilik commented Feb 2, 2026

Background

We are going to move MPUserDefaults to swift target
We need to remove all objc dependencies first from MPUserDeafault. And first step is to hold them in one place so that MPUserDeafault should depends from protocol and only one objc class.
All objc related logic will be moved into this class in next PR.
PR also remove a lot of duplication from code

What Has Changed

  • Convert one class to Objcs
  • Create Connector class to keep all dependencies from objc code in one place
  • Get user defaults from MPUserDeafaultConnector

Screenshots/Video

  • {Include any screenshots or video demonstrating the new feature or fix, if applicable}

Checklist

  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have tested this locally.

Additional Notes

  • {Any additional information or context relevant to this PR}

Reference Issue (For employees only. Ignore if you are an outside contributor)

…g dependencies on MParticle, MPBackendController, etc. from MPUserDefaults during its migration to a Swift target.
@denischilik denischilik force-pushed the Migrate_MPUploadSettings_convertToObjc_updated branch from ccb49b5 to fa71306 Compare February 2, 2026 21:11
…convertToObjc_updated

* workstation/9.0-Release:
  refactor: Migrate MPRoktEvent (#538)
  refactor: migrate SceneDelegateHandler to objc (#539)

# Conflicts:
#	mParticle-Apple-SDK.xcodeproj/project.pbxproj
#	mParticle-Apple-SDK/mParticle.m
@github-actions
Copy link

github-actions bot commented Feb 2, 2026

📦 SDK Size Impact Report

Measures how much the SDK adds to an app's size (with-SDK minus without-SDK).

Metric Target Branch This PR Change
App Bundle Impact 1.61 MB 1.59 MB -16 KB
Executable Impact 896 bytes 896 bytes +N/A
XCFramework Size 6.41 MB 6.32 MB -100 KB

➡️ SDK size impact change is minimal.

Raw measurements

Target branch (workstation/9.0-Release):

{"baseline_app_size_kb":84,"baseline_executable_size_bytes":75464,"with_sdk_app_size_kb":1732,"with_sdk_executable_size_bytes":76360,"sdk_impact_kb":1648,"sdk_executable_impact_bytes":896,"xcframework_size_kb":6568}

This PR:

{"baseline_app_size_kb":84,"baseline_executable_size_bytes":75464,"with_sdk_app_size_kb":1716,"with_sdk_executable_size_bytes":76360,"sdk_impact_kb":1632,"sdk_executable_impact_bytes":896,"xcframework_size_kb":6468}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants