-
Notifications
You must be signed in to change notification settings - Fork 72
refactor: Migrate MPRoktEvent #538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Migrate MPRoktEvent #538
Conversation
📦 SDK Size Impact ReportMeasures how much the SDK adds to an app's size (with-SDK minus without-SDK).
➡️ SDK size impact change is minimal. Raw measurementsTarget branch (workstation/9.0-Release): {"baseline_app_size_kb":84,"baseline_executable_size_bytes":75464,"with_sdk_app_size_kb":1752,"with_sdk_executable_size_bytes":76360,"sdk_impact_kb":1668,"sdk_executable_impact_bytes":896,"xcframework_size_kb":6808}This PR: {"baseline_app_size_kb":84,"baseline_executable_size_bytes":75464,"with_sdk_app_size_kb":1732,"with_sdk_executable_size_bytes":76360,"sdk_impact_kb":1648,"sdk_executable_impact_bytes":896,"xcframework_size_kb":6568} |
jamesnrokt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. One question on the migration docs
nickolas-dimitrakas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
a36c517
bca7f66
6a61cc0
into
workstation/9.0-Release
Background
What Has Changed
Checklist
Reference Issue (For employees only. Ignore if you are an outside contributor)