Skip to content

Conversation

@nickolas-dimitrakas
Copy link
Contributor

Background

  • Part of the broader effort to switch the SDK to source-based distribution instead of shipping as binaries

What Has Changed

  • Converted MPConvertJS.swift to objc

Checklist

  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have tested this locally.

Reference Issue (For employees only. Ignore if you are an outside contributor)

@github-actions
Copy link

github-actions bot commented Jan 29, 2026

📦 SDK Size Impact Report

Measures how much the SDK adds to an app's size (with-SDK minus without-SDK).

Metric Target Branch This PR Change
App Bundle Impact 1.65 MB 1.64 MB -4 KB
Executable Impact 896 bytes 896 bytes +N/A
XCFramework Size 7.64 MB 7.80 MB +160 KB

➡️ SDK size impact change is minimal.

Raw measurements

Target branch (workstation/9.0-Release):

{"baseline_app_size_kb":84,"baseline_executable_size_bytes":75464,"with_sdk_app_size_kb":1772,"with_sdk_executable_size_bytes":76360,"sdk_impact_kb":1688,"sdk_executable_impact_bytes":896,"xcframework_size_kb":7824}

This PR:

{"baseline_app_size_kb":84,"baseline_executable_size_bytes":75464,"with_sdk_app_size_kb":1768,"with_sdk_executable_size_bytes":76360,"sdk_impact_kb":1684,"sdk_executable_impact_bytes":896,"xcframework_size_kb":7984}

@nickolas-dimitrakas nickolas-dimitrakas force-pushed the refactor/migrate-MPConvertJS-to-objc branch from 8c533ac to 2828448 Compare January 29, 2026 22:46
denischilik
denischilik previously approved these changes Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants