Skip to content

Conversation

@nickolas-dimitrakas
Copy link
Contributor

Background

  • Part of the broader effort to switch the SDK to source-based distribution instead of shipping as binaries

What Has Changed

  • Converted MPSideloadedKit.swift to objc

Checklist

  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have tested this locally.

Reference Issue (For employees only. Ignore if you are an outside contributor)

@github-actions
Copy link

github-actions bot commented Jan 28, 2026

📦 SDK Size Impact Report

Measures how much the SDK adds to an app's size (with-SDK minus without-SDK).

Metric Target Branch This PR Change
App Bundle Impact 1.68 MB 1.66 MB -16 KB
Executable Impact 896 bytes 896 bytes +N/A
XCFramework Size 8.02 MB 7.94 MB -76 KB

➡️ SDK size impact change is minimal.

Raw measurements

Target branch (workstation/9.0-Release):

{"baseline_app_size_kb":84,"baseline_executable_size_bytes":75464,"with_sdk_app_size_kb":1800,"with_sdk_executable_size_bytes":76360,"sdk_impact_kb":1716,"sdk_executable_impact_bytes":896,"xcframework_size_kb":8208}

This PR:

{"baseline_app_size_kb":84,"baseline_executable_size_bytes":75464,"with_sdk_app_size_kb":1784,"with_sdk_executable_size_bytes":76360,"sdk_impact_kb":1700,"sdk_executable_impact_bytes":896,"xcframework_size_kb":8132}

Copy link
Collaborator

@BrandonStalnaker BrandonStalnaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nickolas-dimitrakas nickolas-dimitrakas merged commit 2bb4fca into workstation/9.0-Release Jan 29, 2026
12 of 13 checks passed
@nickolas-dimitrakas nickolas-dimitrakas deleted the refactor/migrate-MPSideloadedKit branch January 29, 2026 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants