feat: Update Rokt public methods to match Rokt 5.0 #521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📦 SDK Size Impact ReportMeasures how much the SDK adds to an app's size (with-SDK minus without-SDK).
➡️ SDK size impact change is minimal. Raw measurementsTarget branch (workstation/9.0-Release): {"baseline_app_size_kb":84,"baseline_executable_size_bytes":75464,"with_sdk_app_size_kb":1752,"with_sdk_executable_size_bytes":76360,"sdk_impact_kb":1668,"sdk_executable_impact_bytes":896,"xcframework_size_kb":6808}This PR: {"baseline_app_size_kb":84,"baseline_executable_size_bytes":75464,"with_sdk_app_size_kb":1752,"with_sdk_executable_size_bytes":76360,"sdk_impact_kb":1668,"sdk_executable_impact_bytes":896,"xcframework_size_kb":6828} |
Comment on lines
+186
to
+187
| The `MPRokt` interface has been updated to align with the Rokt SDK 4.14.x API. These changes consolidate multiple callback parameters into a unified event-based callback pattern and standardize parameter naming. | ||
|
|
Contributor
There was a problem hiding this comment.
Suggested change
| The `MPRokt` interface has been updated to align with the Rokt SDK 4.14.x API. These changes consolidate multiple callback parameters into a unified event-based callback pattern and standardize parameter naming. | |
| The `MPRokt` interface has been updated to align with the Rokt SDK 5.0.x API. These changes consolidate multiple callback parameters into a unified event-based callback pattern and standardize parameter naming. |
Comment on lines
+301
to
+319
| ##### purchaseFinalized Method | ||
|
|
||
| **Before (Objective-C):** | ||
|
|
||
| ```objective-c | ||
| [[MParticle sharedInstance].rokt purchaseFinalized:@"checkout" | ||
| catalogItemId:@"item123" | ||
| success:YES]; | ||
| ``` | ||
|
|
||
| **After (Objective-C):** | ||
|
|
||
| ```objective-c | ||
| [[MParticle sharedInstance].rokt purchaseFinalized:@"checkout" | ||
| catalogItemId:@"item123" | ||
| success:YES]; | ||
| ``` | ||
|
|
||
| Note: The method signature remains the same, but the parameter name has changed from `placementId:` to `identifier:`. If you're using named parameters, update accordingly. |
Contributor
There was a problem hiding this comment.
Maybe squish this into before and after since there is no difference between the two examples?
denischilik
reviewed
Jan 28, 2026
Comment on lines
+94
to
+97
| /** | ||
| * Used to subscribe to global Rokt events from all sources. | ||
| * Additional events that are not associated with a view (such as InitComplete) will also be delivered. | ||
| * |
Contributor
There was a problem hiding this comment.
The method name may be misleading, as it suggests returning events rather than registering a listener; a verb-based name like addGlobalEventListener: or subscribeToGlobalEvents: would better reflect its behavior.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
What Has Changed
Screenshots/Video
Checklist
Additional Notes
Reference Issue (For employees only. Ignore if you are an outside contributor)