Skip to content

Bump Version and Dependencies #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mgacy wants to merge 4 commits into
base: main
Choose a base branch
from
+5 −4
Draft

Bump Version and Dependencies #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9cf2162
Update version
mgacy Feb 25, 2024
73bff9b
Move android version specification to properties
mgacy Feb 25, 2024
82b0b69
Specify stable Android version
mgacy Feb 25, 2024
4e42dc9
Specify range of iOS versions
mgacy Feb 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,14 +83,14 @@ repositories {
}

def kotlin_version = getExtOrDefault("kotlinVersion")
def lytics_android_version = getExtOrDefault("lyticsAndroidVersion")

dependencies {
// For < 0.71, this will be from the local maven repo
// For > 0.71, this will be replaced by `com.facebook.react:react-android:$version` by react gradle plugin
//noinspection GradleDynamicVersion
implementation "com.facebook.react:react-native:+"
implementation "org.jetbrains.kotlin:kotlin-stdlib:$kotlin_version"
// FIXME: specify stable version
implementation 'com.github.lytics:android-sdk:main-SNAPSHOT'
implementation "com.github.lytics:android-sdk:$lytics_android_version"
}

1 change: 1 addition & 0 deletions android/gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,4 @@ Sdk_minSdkVersion=21
Sdk_targetSdkVersion=31
Sdk_compileSdkVersion=31
Sdk_ndkversion=21.4.7075529
Sdk_lyticsAndroidVersion=0.9.0
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "react-native-lytics",
"version": "0.0.1",
"version": "0.9.0",
"description": "Lytics SDK for React Native",
"main": "lib/commonjs/index",
"module": "lib/module/index",
Expand Down
2 changes: 1 addition & 1 deletion react-native-lytics.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ Pod::Spec.new do |s|

s.source_files = "ios/**/*.{h,m,mm,swift}"

s.dependency "LyticsSDK"
s.dependency "LyticsSDK", "~> 0.9.0"

# Use install_modules_dependencies helper to install the dependencies if React Native version >=0.71.0.
# See https://github.com/facebook/react-native/blob/febf6b7f33fdb4904669f99d795eba4c0f95d7bf/scripts/cocoapods/new_architecture.rb#L79.
Expand Down