Skip to content

Conversation

@fri0z
Copy link

@fri0z fri0z commented Jul 26, 2025

I added get_upstreams and set_upstreams to the store and wrote a simple implementation for MemoryStore and RedisStore and one test.

The next step is to implement the use of these methods to get upstreams.

Am I moving in the right direction?

@fri0z
Copy link
Author

fri0z commented Jul 26, 2025

Oh, and why does this error occur? "all fields have the same prefix: inner"

@fri0z
Copy link
Author

fri0z commented Aug 3, 2025

@luizfonseca During the development process, a question arose. Or maybe we will store in redis not only the vector of RouteUpstream structures, but the entire Route structure?

@luizfonseca
Copy link
Owner

luizfonseca commented Aug 7, 2025

@fri0z

Am I moving in the right direction?
Yes! It's always tough to test everything, but it's how I'd move too.

During the development process, a question arose. Or maybe we will store in redis not only the vector of RouteUpstream structures, but the entire Route structure?

it's likely that we might need to have a pattern like:

| key                  | routes                              |
| upstream:example.com | <all routes configuration in JSON?> |
| cert:example.com     | ----------------------------------- |

Downside is that it might make hard to eventually update those as we would need to patch the JSON (I plan to allow changes via an admin API in the future)

@fri0z
Copy link
Author

fri0z commented Aug 7, 2025

@luizfonseca I suggest using the proksi:route:{domain} and store json in it in a format similar to the Route structure from config.

This will be more convenient during the subsequent implementation of the REST API. But for this you will need to change the RouteStoreContainer.

@luizfonseca
Copy link
Owner

Ah yes, that's the same line of thought, basically all upstreams injected into => proksi:route:<domain>.

I can check what needs to be done in the RouteStoreContainer

@fri0z
Copy link
Author

fri0z commented Aug 11, 2025

@luizfonseca let's update the key in the specification documentation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants