-
-
Notifications
You must be signed in to change notification settings - Fork 20
Upstreams from store #309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Upstreams from store #309
Conversation
|
Oh, and why does this error occur? "all fields have the same prefix: |
|
@luizfonseca During the development process, a question arose. Or maybe we will store in redis not only the vector of RouteUpstream structures, but the entire Route structure? |
it's likely that we might need to have a pattern like: Downside is that it might make hard to eventually update those as we would need to patch the JSON (I plan to allow changes via an admin API in the future) |
|
@luizfonseca I suggest using the This will be more convenient during the subsequent implementation of the REST API. But for this you will need to change the RouteStoreContainer. |
|
Ah yes, that's the same line of thought, basically all upstreams injected into => I can check what needs to be done in the |
|
@luizfonseca let's update the key in the specification documentation? |
I added get_upstreams and set_upstreams to the store and wrote a simple implementation for MemoryStore and RedisStore and one test.
The next step is to implement the use of these methods to get upstreams.
Am I moving in the right direction?