Fix StructureDefinition Version-Specific Validation and Data Loss Issues #210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dant extension fields across R4, R4B, and R5 data types
- Updated factory.py to introduce version-specific StructureDefinition classes for R4, R4B, and R5. - Replaced ElementDefinitionNode with StructureNode to accommodate version-specific definitions. - Enhanced ResourceFactory to handle different StructureDefinition versions during model construction. - Modified repository.py to implement version detection and validation for StructureDefinitions. - Introduced utility functions to retrieve the appropriate StructureDefinition class based on FHIR version. - Updated repository methods to support version-specific StructureDefinition retrieval and validation.
…Subtraction Operators (#198)
- Updated import statements in `test_fhir_resources_integration.py` for better organization. - Enhanced assertions in `_assert_construct_core_resource` to improve clarity. - Cleaned up whitespace and formatting across multiple test files for consistency. - Added validation error handling in `test_fhir_resources_polymorphism.py`. - Improved error messages in `test_fhir_resources_repository.py` for better debugging. - Refined XML serialization tests in `test_fhir_resources_xml_serialization.py` for clarity and consistency.
commit 3f16bfe Author: Luis Fábregas-Ibáñez <48292540+luisfabib@users.noreply.github.com> Date: Tue Jan 20 16:08:16 2026 +0100 Fix Primitive Extension Placeholder Cardinality for FHIR List-Type Fields (#207) commit 71c2a75 Author: Luis Fábregas-Ibáñez <48292540+luisfabib@users.noreply.github.com> Date: Tue Jan 20 12:50:04 2026 +0100 Add placeholder elements for `Extension.value` type choice values in R4, R4B, R5 (#206) commit 24e79a8 Author: Luis Fábregas-Ibáñez <48292540+luisfabib@users.noreply.github.com> Date: Mon Jan 19 14:58:13 2026 +0100 Fix FHIRPath `$this` context in nested function call (#203) commit e837e1f Author: Luis Fábregas-Ibáñez <48292540+luisfabib@users.noreply.github.com> Date: Mon Jan 19 11:03:21 2026 +0100 Refactor FHIR constraint validators from field-level to model-level validation (#201) commit f5e28f6 Author: Luis Fábregas-Ibáñez <48292540+luisfabib@users.noreply.github.com> Date: Sat Jan 17 17:36:29 2026 +0100 Fix FHIR `eld-11` constraint validation expression R5 `ElementDefinition` (#199) commit 05cbe2b Author: Luis Fábregas-Ibáñez <48292540+luisfabib@users.noreply.github.com> Date: Sat Jan 17 17:11:58 2026 +0100 Fix FHIRPath environment variable precedence in nested evaluations (#197) commit 99cdcd1 Author: Luis Fábregas-Ibáñez <48292540+luisfabib@users.noreply.github.com> Date: Sat Jan 17 16:56:43 2026 +0100 Fix FHIRPath Ambiguity Issues Where Negative Numbers Conflicted With Subtraction Operators (#198) commit 79ec56e Author: Luis Fábregas-Ibáñez <48292540+luisfabib@users.noreply.github.com> Date: Sat Jan 17 14:59:56 2026 +0100 Fix FHIRPath `Union` Operation `TypeError` with Incomparable Types (#196)
commit 3f16bfe Author: Luis Fábregas-Ibáñez <48292540+luisfabib@users.noreply.github.com> Date: Tue Jan 20 16:08:16 2026 +0100 Fix Primitive Extension Placeholder Cardinality for FHIR List-Type Fields (#207) commit 71c2a75 Author: Luis Fábregas-Ibáñez <48292540+luisfabib@users.noreply.github.com> Date: Tue Jan 20 12:50:04 2026 +0100 Add placeholder elements for `Extension.value` type choice values in R4, R4B, R5 (#206) commit 24e79a8 Author: Luis Fábregas-Ibáñez <48292540+luisfabib@users.noreply.github.com> Date: Mon Jan 19 14:58:13 2026 +0100 Fix FHIRPath `$this` context in nested function call (#203) commit e837e1f Author: Luis Fábregas-Ibáñez <48292540+luisfabib@users.noreply.github.com> Date: Mon Jan 19 11:03:21 2026 +0100 Refactor FHIR constraint validators from field-level to model-level validation (#201) commit f5e28f6 Author: Luis Fábregas-Ibáñez <48292540+luisfabib@users.noreply.github.com> Date: Sat Jan 17 17:36:29 2026 +0100 Fix FHIR `eld-11` constraint validation expression R5 `ElementDefinition` (#199) commit 05cbe2b Author: Luis Fábregas-Ibáñez <48292540+luisfabib@users.noreply.github.com> Date: Sat Jan 17 17:11:58 2026 +0100 Fix FHIRPath environment variable precedence in nested evaluations (#197) commit 99cdcd1 Author: Luis Fábregas-Ibáñez <48292540+luisfabib@users.noreply.github.com> Date: Sat Jan 17 16:56:43 2026 +0100 Fix FHIRPath Ambiguity Issues Where Negative Numbers Conflicted With Subtraction Operators (#198) commit 79ec56e Author: Luis Fábregas-Ibáñez <48292540+luisfabib@users.noreply.github.com> Date: Sat Jan 17 14:59:56 2026 +0100 Fix FHIRPath `Union` Operation `TypeError` with Incomparable Types (#196)
commit 3f16bfe Author: Luis Fábregas-Ibáñez <48292540+luisfabib@users.noreply.github.com> Date: Tue Jan 20 16:08:16 2026 +0100 Fix Primitive Extension Placeholder Cardinality for FHIR List-Type Fields (#207) commit 71c2a75 Author: Luis Fábregas-Ibáñez <48292540+luisfabib@users.noreply.github.com> Date: Tue Jan 20 12:50:04 2026 +0100 Add placeholder elements for `Extension.value` type choice values in R4, R4B, R5 (#206) commit 24e79a8 Author: Luis Fábregas-Ibáñez <48292540+luisfabib@users.noreply.github.com> Date: Mon Jan 19 14:58:13 2026 +0100 Fix FHIRPath `$this` context in nested function call (#203) commit e837e1f Author: Luis Fábregas-Ibáñez <48292540+luisfabib@users.noreply.github.com> Date: Mon Jan 19 11:03:21 2026 +0100 Refactor FHIR constraint validators from field-level to model-level validation (#201) commit f5e28f6 Author: Luis Fábregas-Ibáñez <48292540+luisfabib@users.noreply.github.com> Date: Sat Jan 17 17:36:29 2026 +0100 Fix FHIR `eld-11` constraint validation expression R5 `ElementDefinition` (#199) commit 05cbe2b Author: Luis Fábregas-Ibáñez <48292540+luisfabib@users.noreply.github.com> Date: Sat Jan 17 17:11:58 2026 +0100 Fix FHIRPath environment variable precedence in nested evaluations (#197) commit 99cdcd1 Author: Luis Fábregas-Ibáñez <48292540+luisfabib@users.noreply.github.com> Date: Sat Jan 17 16:56:43 2026 +0100 Fix FHIRPath Ambiguity Issues Where Negative Numbers Conflicted With Subtraction Operators (#198) commit 79ec56e Author: Luis Fábregas-Ibáñez <48292540+luisfabib@users.noreply.github.com> Date: Sat Jan 17 14:59:56 2026 +0100 Fix FHIRPath `Union` Operation `TypeError` with Incomparable Types (#196)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the problematic bootstrapped, version-independent StructureDefinition model with proper version-specific model loading and validation to eliminate silent data loss and validation inconsistencies across FHIR versions (R4, R4B, R5).
Changed
validate_structure_definition()with version-specific models instead of bootstrapped StructureDefinition and factory imports updated to use version-specificElementDefinitionandStructureDefinitionmodels from R4/R4B/R5 packages. Fixes Version-Independent StructureDefinition Model Needs Version-Specific Implementation #177Fixed
eld-19andeld-20FHIRPath strings for proper encondingof the regex expressions across all releases. Fixes FHIRPath lexer fails on constraint expressions with escaped quotes #209Removed
ElementDefinitionandStructureDefinition