Add signal functions (modify, pending) #351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Physic69
commented
Dec 27, 2025
Physic69
changed the title
lneto
reviewed
Dec 30, 2025
lneto
reviewed
Dec 30, 2025
lneto
reviewed
Dec 30, 2025
lneto
reviewed
Dec 30, 2025
Physic69
force-pushed
the
idk
branch
2 times, most recently
from
92398d0 to
8f66707
Compare
lneto
reviewed
Jan 1, 2026
lneto
reviewed
Jan 1, 2026
lneto
reviewed
Jan 1, 2026
lneto
reviewed
Jan 1, 2026
lneto
reviewed
Jan 1, 2026
lneto
reviewed
Jan 3, 2026
lib/lualinux.c
Outdated
| sigaddset(&newmask, signum); | ||
|
|
||
| lunatik_try(L, sigprocmask, cmd, &newmask, NULL); | ||
| lua_pushboolean(L, true); |
lneto
reviewed
Jan 3, 2026
lib/lualinux.c
Outdated
| SIGSTATE_ALLOWED, | ||
| }; | ||
|
|
||
| static const char *const sigstate_opts[] = { |
Contributor
There was a problem hiding this comment.
it shouldn't be static, right?
lneto
reviewed
Jan 3, 2026
lib/lualinux.c
Outdated
| [SIGSTATE_BLOCKED] = "blocked", | ||
| [SIGSTATE_PENDING] = "pending", | ||
| [SIGSTATE_ALLOWED] = "allowed", | ||
| NULL |
Contributor
There was a problem hiding this comment.
actually, we don't need this NULL here, right?
lneto
reviewed
Jan 3, 2026
| }; | ||
|
|
||
| int signum = luaL_checkinteger(L, 1); | ||
| enum sigstate_cmd cmd = (enum sigstate_cmd)luaL_checkoption(L, 2, "blocked", sigstate_opts); |
Contributor
There was a problem hiding this comment.
I'm not sure we should have a default = blocked here.. but I will leave this decision to you ;-).. what would be the better ergonomics for this API..
Contributor
Author
There was a problem hiding this comment.
i feel like its better than having pending at the moment
Contributor
There was a problem hiding this comment.
thing is.. we don't need to have any default.. but it's alright to me.. =)
lneto
reviewed
Jan 3, 2026
lneto
reviewed
Jan 3, 2026
lneto
reviewed
Jan 3, 2026
Contributor
lneto
left a comment
lneto
left a comment
There was a problem hiding this comment.
it's looking good to me.. just small comments..
lneto
approved these changes
Jan 4, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.