clean up luahid #347
Closed
clean up luahid #347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lneto
commented
Dec 25, 2025
lneto
commented
- add lunatik_monitor
- remove unecessary branch on error handling
- simplify error levels
- fix style
lneto
commented
Dec 25, 2025
| if (!lua_isboolean(L, -1)) | ||
| lua_pushinteger(L, -EINVAL); | ||
| else | ||
| lua_pushinteger(L, 0); |
Contributor
Author
There was a problem hiding this comment.
@qrsikno2 why should we return 0 if it's not error?
lneto
commented
Dec 25, 2025
| } | ||
|
|
||
| LUAHID_CALLBACK(probe, 2, 1, err); | ||
| LUAHID_CALLBACK(report_fixup, 4, 0, warn); |
Contributor
Author
There was a problem hiding this comment.
@qrsikno2 there was any reason to use warn here?
lneto
commented
Dec 25, 2025
| }; | ||
|
|
||
| static const luaL_Reg luahid_mt[] = { | ||
| {"__index", lunatik_monitorobject}, |
Contributor
Author
There was a problem hiding this comment.
@qrsikno2 there was any reason to not use monitor here?
lneto
commented
Dec 25, 2025
| if (luahid_checkdriver(L, hid, -1)) { \ | ||
| pr_err(#NAME ": invaild driver\n"); \ | ||
| lua_pushinteger(L, -ENXIO); \ | ||
| return 1; \ |
Contributor
Author
There was a problem hiding this comment.
@qrsikno2 please check if it will make any difference.. from Lua perspective, it will just discard the return value if there's no assignment
Contributor
Author
|
@qrsikno2 I noticed that we use both lunatik_run and lunatik_runirq to run different callbacks.. is that guaranteed that the driver will not call them concurrently? |
carloslack
reviewed
Dec 26, 2025
lib/luahid.c
Outdated
| else | ||
| lua_pushinteger(L, 0); | ||
|
|
||
| lua_pushinteger(L, !lua_isboolean(L, -1) ? EINVAL : 0); |
Collaborator
There was a problem hiding this comment.
Maybe you want -EINVAL here
* add lunatik_monitor * remove unecessary branch on error handling * simplify error levels and the overall logics * fix style
Instead of suffixing the callback function with pre and post, use a proper struct with function pointers. Signed-off-by: Ashwani Kumar Kamal <[email protected]>
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.