[otbn,fpv] Get the OTBN SecCm FPV tests working properly #29020
+124
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rswarbrick
added
Component:FPV
The use of ASSERT_*_TRIGGER_ALERT means that they were never really doing anything sensible (but were presumably burning lots of energy!) Since we prove correctness of the alert system separately, we can make this all prove in a minute or two using the "_IN" variants. The tweak I made to prim_fifo_sync when depth=1 stopped the hack that this FPV test previously used from working. Rather than figure out something to black-box, let's just use a stopat and put those assertions into a separate task. I'd love to say that this now works... Unfortunately, FpvSecCmRBignumOnehotCheck_A sees a counterexample. That's because the assertion is just false: the bignum write-enable failure can be squashed for a cycle by a reported SW error and the stopats in use then make a counterexample possible. Tidying that up properly will be quite a bit of work, which I'll do in a follow-up PR. Signed-off-by: Rupert Swarbrick <[email protected]>
rswarbrick
force-pushed
the
otbn-sec-cm-fpv
branch
from
b808698 to
ac722d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of
ASSERT_*_TRIGGER_ALERTmeans that they were never really doing anything sensible (but were presumably burning lots of energy!) Since we prove correctness of the alert system separately, we can make this all prove in a minute or two using the "_IN" variants.The tweak I made to
prim_fifo_syncwhen depth=1 stopped the hack that this FPV test previously used from working. Rather than figure out something to black-box, let's just use a stopat and put those assertions into a separate task.I'd love to say that this now works... Unfortunately,
FpvSecCmRBignumOnehotCheck_Asees a counterexample. That's because the assertion is just false: the bignum write-enable failure can be squashed for a cycle by a reported SW error and the stopats in use then make a counterexample possible.Tidying that up properly will be quite a bit of work, which I'll do in a follow-up PR.